Bug 969776 - Gigabit Site - Wrong preview image on Facebook #1745

Merged
merged 1 commit into from Mar 5, 2014

Conversation

Projects
None yet
2 participants
@retornam
Member

retornam commented Mar 3, 2014

Updated image to right dimesions

@alexgibson

This comment has been minimized.

Show comment Hide comment
@alexgibson

alexgibson Mar 5, 2014

Member

Change looks fine, but I can shave about 50% off the file size for this new image by running it through ImageOptim.

Member

alexgibson commented Mar 5, 2014

Change looks fine, but I can shave about 50% off the file size for this new image by running it through ImageOptim.

@@ -8,7 +8,7 @@
{% block page_desc %}{{_('Gigabit - Description.')}}{% endblock %}
{% block body_id %}gigabit{% endblock %}
{% block body_class %}sand gigabit{% endblock %}
-{% block page_image %}{{ media('img/gigabit/gigabit-wordmark.png') }}?2013-11{% endblock %}
+{% block page_image %}{{ media('img/gigabit/gigabit_wordmarklarge.png') }}?2013-11{% endblock %}

This comment has been minimized.

Show comment Hide comment
@alexgibson

alexgibson Mar 5, 2014

Member

This is just a nit-pick, but the cache buster ?2013-11 should no longer be needed as this is now a new image.

Also for consistency with the rest of the image file names on this page, I'd suggest changing the underscore to a - while we're here.

@alexgibson

alexgibson Mar 5, 2014

Member

This is just a nit-pick, but the cache buster ?2013-11 should no longer be needed as this is now a new image.

Also for consistency with the rest of the image file names on this page, I'd suggest changing the underscore to a - while we're here.

@alexgibson

This comment has been minimized.

Show comment Hide comment
@alexgibson

alexgibson Mar 5, 2014

Member

Just a couple of minor nit-picks, otherwise r+wc

Member

alexgibson commented Mar 5, 2014

Just a couple of minor nit-picks, otherwise r+wc

@retornam

This comment has been minimized.

Show comment Hide comment
@retornam

retornam Mar 5, 2014

Member

@alexgibson I run the image through ImageOptim and made the suggested edits

Member

retornam commented Mar 5, 2014

@alexgibson I run the image through ImageOptim and made the suggested edits

@alexgibson

This comment has been minimized.

Show comment Hide comment
@alexgibson

alexgibson Mar 5, 2014

Member

r+ thanks @retornam

Member

alexgibson commented Mar 5, 2014

r+ thanks @retornam

alexgibson added a commit that referenced this pull request Mar 5, 2014

Merge pull request #1745 from retornam/bug-9669776-gigabit-site
Bug 969776 - Gigabit Site - Wrong preview image on Facebook

@alexgibson alexgibson merged commit 59b958d into mozilla:master Mar 5, 2014

1 check passed

default Jenkins build 'bedrock_github' #3402 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment