[bug1200464] Fixed the redirection bugs in ja locale #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RewriteRule ^/ja/(firefox|thunderbird)/(\d+\.\d+(\.\d+)*)(beta)?/releasenotes(/?|/.+)$ http://mozilla.jp/firefox/$1/$2$3/releasenotes/ [L,R=301] | ||
| RewriteRule ^/ja/mobile/(\d+\.\d+(\.\d+)*)(beta)?/releasenotes(/?|/.+)$ http://mozillla.jp/firefox/android/$1$2/releasenotes/ [L,R=301] | ||
| RewriteRule ^/ja/(firefox|thunderbird)/((android/)?\d+\.\d+(\.\d+)*(beta)?)/releasenotes(/?|/.+)$ http://mozilla.jp/$1/$2/releasenotes/ [L,R=301] | ||
| RewriteRule ^/ja/mobile/(\d+\.\d+(\.\d+)*(beta)?)/releasenotes(/?|/.+)$ http://mozillla.jp/firefox/android/$1$2/releasenotes/ [L,R=301] |
There was a problem hiding this comment.
mozilla.jp currently redirects to www.mozilla.jp, so we should probably save a redirect and change the targets of all of these redirects to www.mozilla.jp -- this will also fix the 'mozillla' typo on line 132, which I missed earlier.
There was a problem hiding this comment.
Actually, I think that we can safely remove line 132 entirely, as /ja/mobile/ should get redirected to /ja/firefox/android/ which would then get caught by the single rule on 131. Also, I believe we can simplify the instances of \d+\.\d+(\.\d+)* to a more readable [0-9.]+, and (/?|/.+) can be safely simplified to /?. How about something like this?
RewriteRule ^/ja/(firefox|thunderbird)/((android/)?[0-9.]+(beta)?)/releasenotes/?$ http://mozilla.jp/$1/$2/releasenotes/ [L,R=301]
chikoski
changed the title
Changed the redirection setting which navigates users with ja-locale to wrong Japanese localized releasenotes. Updated the redirection rule which navigate ja-locale users to Japanese localized releasenotes, to navigate the accesses to Fennec's releasenotes to their Japanese version as well update redirection rules with review comments shortened the redirection rule which redirects Japanese releasenotes to mozilla.jp. Also, a bug in a redirection rule is fixed fixed a redirection bug, which doubled slash in the URL when it redirect ja-locale users to beta releasenotes
|
Looks much better! Thanks! |
pmclanahan
pushed a commit
that referenced
this pull request
Sep 8, 2015
[bug1200464] Fixed the redirection bugs in ja locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will change the site's redirection settings to fix the bug1200464, which navigate users who attempt to access ja-localzed relesenotes to wrong address.