Replace condition html tags with a CSS hack for IE6 (Bug 740917) #51

Closed
wants to merge 5 commits into
from

4 participants

@sgarrity

Drop the conditional HTML tags and replace them with a single "* html" CSS hack for the download button in IE6.

@fwenzel
Mozilla member

interesting.

@icaaq

+1

@icaaq

But i dont see the a profit of adding a extra css rule, I would suggest to just add _margin-left:0; in the existing on as shown below.

.download-button-small .download-link .download-content{
    display:inline-block;
    *display:inline;
    *zoom:1;
    margin-left:-25px;
    _margin-left:0; /* for ie6 only /*
    background-image:url(/media/img/sandstone/buttons/firefox-small.png);
    height:52px;
    padding:0 20px 0 65px;
    overflow:visible;
}
@icaaq

Info on safe css-hacks can be found here http://www.mathiasbynens.be/notes/safe-css-hacks

@sgarrity

Updated with the 'safe-hack' recommendation from icaaq.

@jlongster
Mozilla member

Steven, can you change the PR to merge into dev?

@sgarrity

James, there's a new pull request for dev (I couldn't find any way to change the destination of an existing pull request): #52

@sgarrity sgarrity closed this Apr 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment