Adjust Edge comparison SEM page experiment (Fixes #6371) #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
P3
alexgibson
force-pushed
the
sem-test-adjust
branch
from
b22bb93
to
71a4b89
Compare
alexgibson
force-pushed
the
sem-test-adjust
branch
from
71a4b89
to
659ecda
Compare
alexgibson
added
Review: S
| @@ -46,9 +46,8 @@ | |||
| var cop = new Mozilla.TrafficCop({ | |||
| id: 'experiment_firefox_new_edge', | |||
| variations: { | |||
| 'xv=edge&v=a': 33, // control | |||
There was a problem hiding this comment.
Oh that's where the double xvs have been coming from 🤦♀️.
| @@ -46,9 +46,8 @@ | |||
| var cop = new Mozilla.TrafficCop({ | |||
| id: 'experiment_firefox_new_edge', | |||
There was a problem hiding this comment.
We should update the experiment ID for saftey's sake. I doubt we'll see many any users returning through a paid media buy like this but if they do we don't want traffic cop sending them back to v=1 because that's in their stored cookie.
stephaniehobson
requested changes
Nov 7, 2018
alexgibson
force-pushed
the
sem-test-adjust
branch
from
659ecda
to
552e481
Compare
|
Thanks @stephaniehobson updated |
stephaniehobson
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/firefox/new/?xv=edgeto use what was?v=2.?v=3as the new variation to test against control.Issue / Bugzilla link
#6371
Testing
/firefox/new/?xv=edgeURL.