[fix #6488] Add FxA OAuth relier. #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpetto
force-pushed
the
fix-6488-fxa-oauth-relier-functionality
branch
from
cb8d94e
to
7702789
Compare
jgmize
approved these changes
Nov 20, 2018
|
|
||
| var d = new Date(); | ||
| d.setTime(d.getTime() + (cookieDays * 24 * 60 * 60 * 1000)); | ||
| Mozilla.Cookies.setItem(stateStorageKey, state, d.toUTCString(), '/'); |
There was a problem hiding this comment.
We should probably be using a signed cookie here, but it's not a blocker for this use case.
| // add required params to the token fetch request | ||
| destURL += '?utm_campaign=firefox-concert-series-q4-2018&utm_source=mozilla.org'; | ||
|
|
||
| fetch(destURL).then(function(resp) { |
There was a problem hiding this comment.
Ideally we'd use a circuit breaker here to handle a slow or unresponsive metrics endpoint.
There was a problem hiding this comment.
As the metrics data here is not critical, I've removed the fetch call being a blocker. The user can now submit the form whenever they are ready. If the fetch call completed beforehand, they'll have metrics data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds FxA OAuth relier functionality. Also adds very basic templates for testing the flow. (All templates and corresponding URLs are behind a switch to test flow on stage, but wait until templates are finished for prod.)
Testing
https://www-demo5.allizom.org/firefox/concerts/
The above OAuth flow should work (redirecting you to
/firefox/concerts/with a cookie that will display a "Verified" message instead of the initial form/link) for all browsers, both signed in and out of FxA.