Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade New Relic to 4.18.0.118 to fix #7146 #7147

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@jgmize
Copy link
Member

commented May 2, 2019

Description

Upgrade New Relic to 4.18.0.118

Issue / Bugzilla link

#7146

Testing

Verify working in https://rpm.newrelic.com

@jgmize jgmize requested a review from pmac May 2, 2019

@jgmize

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

got some import errors on the test image in https://circleci.com/gh/mozilla/bedrock/18394 that I'm researching now:

^@^@+ flake8 bedrock lib tests
bedrock/firefox/tests/test_base.py:385:1: F821 undefined name 'eq_'
bedrock/firefox/tests/test_base.py:387:1: F821 undefined name 'ok_'
bedrock/firefox/tests/test_base.py:388:1: F821 undefined name 'eq_'
bedrock/firefox/tests/test_base.py:396:1: F821 undefined name 'eq_'
bedrock/firefox/tests/test_base.py:398:1: F821 undefined name 'ok_'
bedrock/firefox/tests/test_base.py:399:1: F821 undefined name 'eq_'
6       F821 undefined name 'eq_'
Makefile:89: recipe for target 'test-image' failed
@pmac

pmac approved these changes May 2, 2019

Copy link
Member

left a comment

Changes are good. Once the test issue is fixed and this is rebased please merge at will..

@jgmize

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

will rebase on master once #7148 is merged

@jgmize jgmize force-pushed the jgmize:upgrade-nr branch from 94b9af9 to 0749031 May 2, 2019

@jgmize

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

Something odd: https://circleci.com/gh/mozilla/bedrock/18404 failed on 0749031 with the same errors after I rebased https://github.com/jgmize/bedrock/commits/upgrade-nr on master

@jgmize jgmize force-pushed the jgmize:upgrade-nr branch from 30064ba to a9e5f62 May 2, 2019

@jgmize

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

found an issue with my previous rebase, this one should hopefully fix it.

@jgmize jgmize merged commit c3625c7 into mozilla:master May 2, 2019

2 checks passed

ci/circleci: test_js Your tests passed on CircleCI!
Details
ci/circleci: test_py Your tests passed on CircleCI!
Details

@jgmize jgmize deleted the jgmize:upgrade-nr branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.