Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ability to use custom newrelic.ini #7150

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@jgmize
Copy link
Member

commented May 2, 2019

Description

After #7149 was merged the deployment in https://ci.vpn1.moz.works/blue/organizations/jenkins/bedrock_multibranch_pipeline/detail/master/1643/pipeline failed, with the following traceback:

[2019-05-02 19:31:07 +0000] [1693] [ERROR] Exception in worker process
Traceback (most recent call last):
  File "/venv/lib/python2.7/site-packages/gunicorn/arbiter.py", line 578, in spawn_worker
    worker.init_process()
  File "/venv/lib/python2.7/site-packages/gunicorn/workers/base.py", line 126, in init_process
    self.load_wsgi()
  File "/venv/lib/python2.7/site-packages/gunicorn/workers/base.py", line 135, in load_wsgi
    self.wsgi = self.app.wsgi()
  File "/venv/lib/python2.7/site-packages/gunicorn/app/base.py", line 67, in wsgi
    self.callable = self.load()
  File "/venv/lib/python2.7/site-packages/gunicorn/app/wsgiapp.py", line 65, in load
    return self.load_wsgiapp()
  File "/venv/lib/python2.7/site-packages/gunicorn/app/wsgiapp.py", line 52, in load_wsgiapp
    return util.import_app(self.app_uri)
  File "/venv/lib/python2.7/site-packages/gunicorn/util.py", line 352, in import_app
    __import__(module)
  File "/app/wsgi/app.py", line 11, in <module>
    newrelic_ini = config('NEWRELIC_PYTHON_INI_FILE', default='')
NameError: name 'config' is not defined

We can't use config or os without importing them first, but newrelic needs to be imported first. Fortunately, we do not appear to actually use a custom newrelic.ini anywhere that I have been able to find, so we can simply remove it.

@jgmize jgmize requested a review from pmac May 2, 2019

@pmac

pmac approved these changes May 2, 2019

Copy link
Member

left a comment

Looks good. I'm sure this is vestigial from the old data-center days. 👍

@pmac pmac merged commit 5b8b210 into mozilla:master May 2, 2019

1 of 2 checks passed

ci/circleci: test_py CircleCI is running your tests
Details
ci/circleci: test_js Your tests passed on CircleCI!
Details

@jgmize jgmize deleted the jgmize:rm-customizable-newrelic.ini branch May 2, 2019

jgmize added a commit to mozmeao/www-config that referenced this pull request May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.