Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Puente and fix args for l10n management commands #7182

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
4 participants
@pmac
Copy link
Member

commented May 13, 2019

Django 1.11 switched to argparse for arguments and added a method for adding them. This was missed for the l10n commands during the Django upgrade. Also the Puente library needed to be updated to a supported version.

Fix #7181

Upgrade Puente and fix args for l10n management commands
Django 1.11 switched to argparse for arguments and added a method
for adding them. This was missed for the l10n commands during the
Django upgrade. Also the Puente library needed to be updated to a
supported version.

Fix #7181
@pmac

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@alexgibson I don't think tests are going to catch these changes. Best thing will be to pull down my branch and try the extraction.

@alexgibson
Copy link
Member

left a comment

I updated and ran the scripts locally and string extraction worked 👍

I'll not merge this just yet, incase anyone else may want to review. But it's an (uneducated) r+ from me. Thanks for the quick response @pmac 💯

@pmac pmac requested a review from jpetto May 13, 2019

@pmac

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

Sounds good. I'll see if @jpetto can also take a quick look and then we can get this in. I believe it should be safe to land since the commands are currently broken.

@jgmize

jgmize approved these changes May 13, 2019

Copy link
Member

left a comment

👍

@jpetto

jpetto approved these changes May 13, 2019

Copy link
Member

left a comment

LGTM. :shipit:

@jpetto jpetto merged commit 05c453c into mozilla:master May 13, 2019

2 checks passed

ci/circleci: test_js Your tests passed on CircleCI!
Details
ci/circleci: test_py Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.