Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Protocol 7 - including new fonts (#7102) #7227

Merged
merged 2 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@stephaniehobson
Copy link
Contributor

commented May 23, 2019

Description

  • Update to Protocol 7
    • review use of text size mixins to see where decrease needed
    • update mixin names to use new naming (font-base, font-mozilla)
  • Add Inter to font folder
  • Remove system font include and usages
  • Remove references to Open Sans from all Protocol files
  • Update font used on logos in media/img/logos/firefox/
    • Update image sizes in places where these logos are used
  • Remove "confetti" and "blob" images

Issue / Bugzilla link

Close #7102

Testing

You will need to run make build to pull the new version of Protocol in.

Impacted pages on demo:

@stephaniehobson

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

Review can begin but hold off on merge until design review is finished.

@stephaniehobson stephaniehobson changed the title Protocol 7 - including new fonts (#7102) Upgrade to Protocol 7 - including new fonts (#7102) May 23, 2019

@stephaniehobson stephaniehobson referenced this pull request May 27, 2019

Closed

Trailhead - WNP 67.0.1 - Design Review/Feedback #7244

1 of 4 tasks complete

@craigcook craigcook self-assigned this May 31, 2019

@stephaniehobson stephaniehobson force-pushed the stephaniehobson:protocol-7 branch from 57e7bc0 to 8ebf6de May 31, 2019

@jgmize
Copy link
Member

left a comment

I don't normally weigh in on font decisions, but for the reasons I gave in mozmeao/infra#1118 (comment) I am opposed to using Sharp Sans AKA Firefox Sans on bedrock.

Show resolved Hide resolved media/css/protocol/base/fonts/_firefox.scss Outdated
Show resolved Hide resolved media/css/protocol/protocol.scss Outdated

@stephaniehobson stephaniehobson force-pushed the stephaniehobson:protocol-7 branch from 8ebf6de to d0d343f Jun 4, 2019

@craigcook
Copy link
Member

left a comment

This all looks great. There's still a reference to the open-sans mixin in css/hubs/_sub-nav-protocol.scss which is making Sass/stylelint unhappy. I think this needs a rebase by now and probably some light touches on the new pages that were added for trailhead, namely the new accounts, download, thanks, and whatsnew pages.

@jgmize

jgmize approved these changes Jun 6, 2019

stephaniehobson added some commits May 17, 2019

Protocol 7 - including new fonts (#7102)
- Update to Protocol 7
  - review use of text size mixins to see where decrease needed
  - update mixin names to use new naming (font-base, font-mozilla)
- Add Inter to font folder
- Remove system font include and usages
- Remove references to Open Sans from all Protocol files
- Update font used on logos in `media/img/logos/firefox/`
  - Update image sizes in places where these logos are used
- Remove "confetti" and "blob" images

@stephaniehobson stephaniehobson force-pushed the stephaniehobson:protocol-7 branch from d0d343f to ba44ebc Jun 6, 2019

@stephaniehobson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Updated.

@craigcook craigcook merged commit 1785c2b into mozilla:master Jun 11, 2019

2 checks passed

ci/circleci: test_js Your tests passed on CircleCI!
Details
ci/circleci: test_py Your tests passed on CircleCI!
Details

@stephaniehobson stephaniehobson deleted the stephaniehobson:protocol-7 branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.