Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean untracked directories as well as files in 'make clean'; fix #7866 #7868

Merged
merged 1 commit into from Oct 10, 2019

Conversation

jgmize
Copy link
Contributor

@jgmize jgmize commented Oct 9, 2019

#Description

Add a -d argument to the git clean flag executed as part of make clean to remove untracked directories as well as files. See https://git-scm.com/docs/git-clean#Documentation/git-clean.txt--d

Issue / Bugzilla link

#7866

Testing

  1. create a new directory & file
  2. make clean
  3. See that the untracked directory is now removed.

@jgmize jgmize requested a review from alexgibson October 9, 2019 20:59
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed this branch to run-integration-tests and everything passed. LGTM, thanks @jgmize 💯

https://ci.vpn1.moz.works/blue/organizations/jenkins/bedrock_multibranch_pipeline/detail/run-integration-tests/385/pipeline

@alexgibson alexgibson merged commit c253dc4 into mozilla:master Oct 10, 2019
@jgmize jgmize deleted the git-clean-d branch October 10, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants