Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade urllib3 to 1.25.6 to fix #8078 #8079

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@jgmize
Copy link
Member

jgmize commented Nov 5, 2019

Description

Version 1.25 now verifies HTTPS connections by default
https://urllib3.readthedocs.io/en/latest/user-guide.html#certificate-verification

Issue / Bugzilla link

#8078

Version 1.25 now verifies HTTPS connections by default
https://urllib3.readthedocs.io/en/latest/user-guide.html#certificate-verification
@jgmize jgmize requested a review from alexgibson Nov 5, 2019
@jgmize jgmize changed the title Upgrade urllib3 to 1.25.6 to fix Upgrade urllib3 to 1.25.6 to fix #8078 Nov 5, 2019
@jgmize

This comment has been minimized.

Copy link
Member Author

jgmize commented Nov 5, 2019

This failed on CircleCI with the following:

pluggy.manager.PluginValidationError: Plugin 'appium_driver' could not be loaded: (urllib3 1.25.6 (/venv/lib/python3.7/site-packages), Requirement.parse('urllib3<1.25,>=1.21.1'), {'requests'})!

This is due to psf/requests#5067 which was fixed by psf/requests#5092 so upgrading requests to 2.22.0 should resolve this issue.

@alexgibson alexgibson merged commit 32d1c13 into mozilla:master Nov 5, 2019
2 checks passed
2 checks passed
ci/circleci: test_js Your tests passed on CircleCI!
Details
ci/circleci: test_py Your tests passed on CircleCI!
Details
@jgmize jgmize deleted the jgmize:upgrade-urllib3 branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.