Add coarse UA detection to stub attribution (Fixes #8405) #8483
Conversation
alexgibson
force-pushed the
alexgibson:stub-attribution-ua
branch
from
e20dbfd
to
ba2777d
|
Nice work! |
| if (/Opera/.test(ua)) { | ||
| return 'opera'; |
Comment on lines
+179
to
+180
Mardak
Feb 6, 2020
Member
No need to fix this, as we didn't list Opera in the bug and this is acceptable as a false positive. FYI, here's the user agent from Opera on mac:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36 OPR/66.0.3515.72
and windows:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.87 Safari/537.36 OPR/66.0.3515.44
No need to fix this, as we didn't list Opera in the bug and this is acceptable as a false positive. FYI, here's the user agent from Opera on mac:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36 OPR/66.0.3515.72
and windows:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.87 Safari/537.36 OPR/66.0.3515.44
alexgibson
Feb 6, 2020
Author
Member
If Opera isn't a concern I'll go ahead and remove this altogether 👍
If Opera isn't a concern I'll go ahead and remove this altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
uaparameter to stub attribution.Issue / Bugzilla link
#8405
Testing
Demo: https://www-demo5.allizom.org/en-US/