Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mkdocs via requirements files #2528

Merged
merged 3 commits into from Nov 26, 2021
Merged

Install mkdocs via requirements files #2528

merged 3 commits into from Nov 26, 2021

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Nov 25, 2021

This makes doc generation "work out of the box" and simplifies CI
somewhat.

@wlach wlach requested a review from ANich November 25, 2021 19:54
This makes doc generation "work out of the box" and simplifies CI
somewhat.
Copy link
Contributor

@ANich ANich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM seems like it streamlines local docs development too. Looks like CI is complaining about re-running pip compile?

@wlach
Copy link
Contributor Author

wlach commented Nov 26, 2021

LGTM seems like it streamlines local docs development too. Looks like CI is complaining about re-running pip compile?

Yup, looks like it needed some extra comments to match (since I used a different version of python to generate). A bit of a gotcha.

@wlach wlach enabled auto-merge (squash) November 26, 2021 18:05
@wlach wlach added the usability Issues that make bigquery-etl hard to contribute to or use label Nov 26, 2021
@wlach wlach merged commit b6b146b into main Nov 26, 2021
@wlach wlach deleted the mkdocs-requirements branch November 26, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Issues that make bigquery-etl hard to contribute to or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants