Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the documentation reproducible #465

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@lamby
Copy link
Contributor

commented Aug 7, 2019

Whilst working on the Reproducible Builds effort I noticed that python-bleach could not be built reproducibly.

This is because the documentation included a default arguments that was (originally) generated from a frozenset type which are iterated over at runtime in a nondeterministic order.

This commit therefore ensures a regular expression is constructed in a deterministic manner, rendering the documentation reproducible.

This bug was originally filed in Debian as #934120.

Make the documentation reproducible.
Whilst working on the Reproducible Builds effort [0] we noticed
that python-bleach could not be built reproducibly.

This is because the documentation included a default arguments that
was (originally) generated from a "frozenset" type which are iterated
over at runtime in a nondeterministic order.

This commit therefore ensures a regular expression is constructed in
a deterministic manner, rendering the documentation reproducible.

This bug was originally filed in Debian as #934120 [1]

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/934120
@jezdez
jezdez approved these changes Sep 3, 2019
Copy link
Member

left a comment

This makes sense to me, thank you @lamby!

@jezdez

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@willkg Hey, so I noticed I lost access to this repo, any reason for this?

@willkg

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@jezdez I don't work on Bleach anymore, so generally I wouldn't know and you should talk with @g-k. However, I did do a pass a week ago while hanging with @g-k in Portland and dropped admin/owner permissions from anyone who wasn't currently a maintainer. You probably lost it then.

@lamby

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Thanks folks :)

@jezdez

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

@jezdez I don't work on Bleach anymore, so generally I wouldn't know and you should talk with @g-k. However, I did do a pass a week ago while hanging with @g-k in Portland and dropped admin/owner permissions from anyone who wasn't currently a maintainer. You probably lost it then.

Ack, it would have been nice to be informed about this decision :)

@g-k
g-k approved these changes Sep 5, 2019
Copy link
Collaborator

left a comment

lgtm thank you!

@g-k g-k merged commit d1a2d7b into mozilla:master Sep 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.