Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The image is not displayed for the first resolved breach on a newly created profile. #1508

Closed
obotisan opened this issue Jan 27, 2020 · 4 comments

Comments

@obotisan
Copy link

@obotisan obotisan commented Jan 27, 2020

Affected versions]:

  • Firefox 72.0.2

[Affected Platforms]:

  • Windows 10 x64
  • Windows 7 x64
  • macOS 10.13
  • Ubuntu 18.04 x64

[Steps to reproduce]:

  1. Navigate to https://monitor-v2.herokuapp.com/
  2. Create a new Firefox Monitor account with a breached email.
  3. Click on "Resolve this breach" link.
  4. Click on the "Mark as Resolved" button.

[Expected result]:

  • This image is displayed:
    2020-01-10_12h05_32

[Actual result]:

  • This image is displayed:
    Screenshot from 2020-01-23 14-48-16

[Regression]:

  • N/A

[Additional Info]:

  • This reproduces on Chrome, too.
  • It only happens on the first resolved breach on a newly created profile.
@LaurentiuApahideanSV
Copy link

@LaurentiuApahideanSV LaurentiuApahideanSV commented Jan 28, 2020

The issue also occurs on Android under the same behavior and repro steps.

Affected versions

Firefox Release 68.4.2, Beta 68.5b5
Chrome Chrome 79.0.3945.136

Devices used

OnePlus 6t (Android 9)

@LaurentiuApahideanSV
Copy link

@LaurentiuApahideanSV LaurentiuApahideanSV commented Jan 31, 2020

The issue also occurs on iOS under the same behavior and repro steps.

Affected versions

Firefox for iOS 22 (17157)
Safari

Devices used

iPhone XS MAX iOS 12.4

lesleyjanenorton added a commit that referenced this issue Feb 4, 2020
@lesleyjanenorton lesleyjanenorton self-assigned this Feb 4, 2020
@lesleyjanenorton lesleyjanenorton added this to Backlog in Breach Alerts via automation Feb 4, 2020
@lesleyjanenorton lesleyjanenorton moved this from Backlog to Review in Breach Alerts Feb 4, 2020
@obotisan
Copy link
Author

@obotisan obotisan commented Feb 6, 2020

We verified the fix on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64. We can't reproduce the issue anymore.

@lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Feb 6, 2020

Thank you @obotisan!

Breach Alerts automation moved this from Review to Done Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Breach Alerts
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants