Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Circle sign into Docker #1962

Closed
groovecoder opened this issue Oct 13, 2020 · 0 comments
Closed

Have Circle sign into Docker #1962

groovecoder opened this issue Oct 13, 2020 · 0 comments
Assignees
Labels

Comments

@groovecoder
Copy link
Member

groovecoder commented Oct 13, 2020

Just like mozilla/ichnaea#1369. (See mozilla/ichnaea@6655b9b...f8da96d for Circle code changes.) Except, unlike ichnaea, we DON'T pull the mozilla/cidockerbases:docker-latest image from docker hub during our builds. So we only use docker hub to pull the base images for our build (and integration tests), and to upload our tagged builds.

@groovecoder groovecoder self-assigned this Oct 13, 2020
@groovecoder groovecoder added this to Review in Breach Alerts Oct 13, 2020
groovecoder added a commit that referenced this issue Oct 13, 2020
fix #1962: sign into docker hub during build step
Breach Alerts automation moved this from Review to Done Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Breach Alerts
  
Done
Development

No branches or pull requests

1 participant