Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element img is missing required attribute src #3037

Open
pdehaan opened this issue May 11, 2023 · 1 comment
Open

Element img is missing required attribute src #3037

pdehaan opened this issue May 11, 2023 · 1 comment
Labels
jira-synced Jira task created for this

Comments

@pdehaan
Copy link
Collaborator

pdehaan commented May 11, 2023

Per https://html5.validator.nu/?doc=https%3A%2F%2Fmonitor.firefox.com&showimagereport=yes

Seeing 6 instances of the "Element img is missing required attribute src." error.

From line 49, column 13; to line 49, column 183

<img class='monitor-logo' srcset='/images/monitor-logo-transparent.webp 213w, /images/monitor-logo-transparent@2x.webp 425w' width='213' height='33' alt='Firefox Monitor'>

Quoth the MDN:

Using src with an image set

When using a set of images with the srcset property, the src serves as either a fallback for older browsers, or as the size of the image.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/src#using_src_with_an_image_set

So it appears that the src is still required/recommended as a fallback when using srcset. 🤷

@pdehaan
Copy link
Collaborator Author

pdehaan commented May 11, 2023

I'll call it related, but there's another 6× errors re: sizes attribute on the <img> tag:

When the srcset attribute has any image candidate string with a width descriptor, the sizes attribute must also be present.

From line 49, column 13; to line 49, column 183

<img class='monitor-logo' srcset='/images/monitor-logo-transparent.webp 213w, /images/monitor-logo-transparent@2x.webp 425w' width='213' height='33' alt='Firefox Monitor'>

if you want to track this separately, we can convert the comment into a new issue (or do your Jira thing or whatever).

@EMMLynch EMMLynch added the jira-synced Jira task created for this label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-synced Jira task created for this
Projects
None yet
Development

No branches or pull requests

2 participants