Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can subscribe with an email that contains a typo #321

Open
obotisan opened this issue Sep 3, 2018 · 1 comment
Open

You can subscribe with an email that contains a typo #321

obotisan opened this issue Sep 3, 2018 · 1 comment

Comments

@obotisan
Copy link

@obotisan obotisan commented Sep 3, 2018

[Affected versions]:

  • Firefox 62.0
  • Firefox 63.0a1

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

[Steps to reproduce]:

  1. Access this link: https://fx-breach-alerts.herokuapp.com/
  2. Click on the "Subscribe" button.
  3. In the email field write an email address that contains a typo (e.g. test@gmsil.com).

[Expected result]:

  • An error that the email address is invalid or asking if the user wanted to write "@gmail.com" is displayed.

[Actual result]:

  • The subscription is done successfully.

[Regression]:

  • I don't think this is a regression.

[Notes]:

  • Please look at the attached gif.

peek 2018-09-03 17-45

@pdehaan
Copy link
Collaborator

@pdehaan pdehaan commented Sep 3, 2018

I believe fxa-content-server uses mailcheck to check for some domain typos. We could sync up with them and see how that’s working out, or if they have any other suggestions.

create_a_firefox_account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants