Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The “Verify your subscription” dialog is different from the one in the mock-ups (“Confirm your Account”) #334

Closed
obotisan opened this issue Sep 5, 2018 · 2 comments
Assignees

Comments

@obotisan
Copy link

@obotisan obotisan commented Sep 5, 2018

[Affected versions]:

  • Firefox 62.0
  • Firefox 64.0a1

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

[Steps to reproduce]:

  1. Navigate to https://fx-breach-alerts.herokuapp.com/
  2. Provide a valid email address and click on the “Submit” button.
  3. Inspect the “Verify your subscription” dialog.

[Expected result]:

  • The dialog contains “...sent to email@email.com” string.
  • The dialog contains the “Not in inbox or spam folder? Resend” link.

[Actual result]:

  • The dialog does not contain “...sent to email@email.com” string.
  • The dialog does not contain the “Not in inbox or spam folder? Resend” link.

[Regression]:

  • I don't think this is a regression.

[Notes]:
Please look at the image: https://drive.google.com/file/d/1OCxmYgGpfFrksa9cMVqB--qOIoTK4M-9/view

@tcinotto
Copy link
Collaborator

@tcinotto tcinotto commented Sep 5, 2018

Separate issues:

  1. Resend button
  2. Show email.
lesleyjanenorton added a commit that referenced this issue Sep 6, 2018
-Fixes #334
Shows the submitted email address in modal and allows data to be resent.
@CiprianGeorgiu
Copy link

@CiprianGeorgiu CiprianGeorgiu commented Sep 7, 2018

@lesleyjanenorton Hi, is this issue supposed to be fixed, I am still seeing the same issue originally reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants