Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Close” button inside the “Subscribe to Firefox Monitor” dialog does not have the correct hover state #335

Closed
obotisan opened this issue Sep 5, 2018 · 2 comments
Assignees

Comments

@obotisan
Copy link

@obotisan obotisan commented Sep 5, 2018

[Affected versions]:

  • Firefox 62.0
  • Firefox 64.0a1

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

[Steps to reproduce]:

  1. Navigate to https://fx-breach-alerts.herokuapp.com/
  2. Click on the Subscribe button.
  3. Hover with the cursor over the "Close" button.

[Expected result]:

  • The "Close" button is highlighted with a darker blue color.

[Actual result]:

  • The "Close" button is highlighted with a light grey color.

[Regression]:

  • I don't think this is a regression.

[Notes]:
Please look at the image:

imgpsh_fullsize

@lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Sep 10, 2018

Fixed in #378

@CiprianGeorgiu
Copy link

@CiprianGeorgiu CiprianGeorgiu commented Sep 12, 2018

HI @lesleyjanenorton, I have verified this issue on herokuapp and now the "Close" button gets underlined when hovering over it. I just want to make sure that this is the right behavior since looking at the visual specs I can see a different hover state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants