Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website logos and informative icons from the email report are not displayed #340

Closed
CiprianGeorgiu opened this issue Sep 5, 2018 · 2 comments
Assignees
Milestone

Comments

@CiprianGeorgiu
Copy link

@CiprianGeorgiu CiprianGeorgiu commented Sep 5, 2018

[Affected versions]:

  • Firefox 62.0

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

[Steps to reproduce]:

  1. Launch Firefox.
  2. Go to https://fx-breach-alerts.herokuapp.com/
  3. Subscribe with a valid email address (compromised or uncompromised).
  4. Click on the "Verify your subscription" link from Inbox.

[Expected result]:

  • The website logos (in case of a brached email report) and the four icons (not breached) from the email report are properly displayed.

[Actual result]:

[Regression]:

  • Not a regression.
@pdehaan
Copy link
Collaborator

@pdehaan pdehaan commented Sep 5, 2018

I think this was from #323 (comment)

Still Needed:

  • decision on what to put in place of logo images since thou shalt not send svgs to gmail.

Not sure if something like convert-svg-to-png would work here. Basically when we grab new logos from HIBP servers, we'd need to convert any SVGs to PNGs (for better web+email interop), then delete the possibly now redundant SVGs, run all PNGs though imagemin optimizer, and... that may be it.

@groovecoder
Copy link
Member

@groovecoder groovecoder commented Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants