Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user is redirected to the Firefox Monitor homepage after refreshing the unsubscribe page #355

Closed
CiprianGeorgiu opened this issue Sep 6, 2018 · 6 comments
Assignees
Labels

Comments

@CiprianGeorgiu
Copy link

@CiprianGeorgiu CiprianGeorgiu commented Sep 6, 2018

[Affected versions]:

  • latest Nightly 64.0a1
  • Beta 63.0b3
  • Release 62.0

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

[Prerequisites]:

  • the user is already subscribed and has the "Firefox Monitor: Unsubscribe" page displayed

[Steps to reproduce]:

  1. Refresh the "Firefox Monitor: Unsubscribe" page.

[Expected result]:

  • The "Firefox Monitor: Unsubscribe" page remains displayed.

[Actual result]:

  • The user is redirected to Firefox Monitor homepage.

[Regression]:

  • Not a regression.

[Additional info]:

  • see screencast
    hf
@groovecoder
Copy link
Member

@groovecoder groovecoder commented Sep 6, 2018

Note: this is the fix for #316.

@jsavory - what should the user see if they refresh the unsubscribe page?

@lesleyjanenorton lesleyjanenorton self-assigned this Sep 9, 2018
@nhnt11
Copy link
Member

@nhnt11 nhnt11 commented Sep 12, 2018

@groovecoder @lesleyjanenorton I think the "you are no longer subscribed" view should be separate from /user/unsubscribe - why not serve it as a static page or something so that the browser doesn't ask to resend post data?

@groovecoder
Copy link
Member

@groovecoder groovecoder commented Sep 12, 2018

@nhnt11 interesting ...

In my head I'm avoiding any pages that say something like "You are no longer subscribed" (I'm still not sure I like the "This email address is not subscribed to Firefox Monitor") because I'm extra paranoid about user enumeration against this service. (@psiinon @moz-jvehent - should I be this paranoid?)

I think @lesleyjanenorton has a fix incoming for this though.

@groovecoder
Copy link
Member

@groovecoder groovecoder commented Sep 12, 2018

This is closed as of #406.

Note: the intended behavior is now that refreshing the unsubscribe form after submitted feedback should show the user an error

@jvehent
Copy link

@jvehent jvehent commented Sep 13, 2018

should I be this paranoid?

Probably. User enumerations aren't the worst of attacks, but since this is a security service, I think it's fair to take extra precautions.

@nhnt11
Copy link
Member

@nhnt11 nhnt11 commented Sep 13, 2018

Cool, @groovecoder, I didn't mean to draw attention to the language, I was just using that phrase to identify the view I was talking about :) Anyway, looks like this has been taken care of!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants