Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user can subscribe with the same email account #358

Closed
obotisan opened this issue Sep 6, 2018 · 2 comments
Closed

The user can subscribe with the same email account #358

obotisan opened this issue Sep 6, 2018 · 2 comments

Comments

@obotisan
Copy link

@obotisan obotisan commented Sep 6, 2018

[Affected versions]:

  • Firefox 62.0
  • Firefox 64.0a1

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

[Steps to reproduce]:

  1. Navigate to https://fx-breach-alerts.herokuapp.com/
  2. Click on the Subscribe button.
  3. Write a valid email address and confirm the subscription.
  4. Repeat steps 1 and 2.
  5. Write the same email as in step 3.

[Expected result]:

  • An error that the email is already subscribed to Firefox Monitor should be displayed.

[Actual result]:

  • The user can subscribe with the same email over and over again.

[Regression]:

  • I don't think this is a regression.

[Notes]:

  • Considering the fact that these emails are already being monitored, there should be a way to notify people that their email is already subscribed to this service.
@groovecoder
Copy link
Member

@groovecoder groovecoder commented Sep 6, 2018

Need a UX decision here ...

To help prevent user enumeration attacks, we may not necessarily want to show that the email is already subscribed to Firefox Monitor.

@jsavory - is it okay to leave this behavior as-is?

We have code to prevent sending duplicate notifications to duplicate subscribers. We could add code to delete duplicate subscriber records periodically too, but that will just be data cleanup - no effect on the user receiving alerts.

We should at least add code to delete all duplicate subscriber records when a user clicks an Unsubscribe link.

@lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Feb 11, 2019

Closing since this will no longer be possible post-FxA integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants