Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can unsubscribe from Firefox Monitor with the same account more than once #364

Closed
obotisan opened this issue Sep 6, 2018 · 3 comments
Closed
Assignees

Comments

@obotisan
Copy link

@obotisan obotisan commented Sep 6, 2018

[Affected versions]:

  • Firefox 62.0
  • Firefox 64.0a1

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 16.04 x64

[Steps to reproduce]:

  1. Navigate to https://fx-breach-alerts.herokuapp.com/
  2. Click on the Subscribe button.
  3. Write a valid email address and confirm the subscription.
  4. From the report email "Unsubscribe" and see the process through and close the tab.
  5. Repeat step 4.

[Expected result]:

  • An error that the email is already unsubscribed to Firefox Monitor should be displayed.

[Actual result]:

  • The Firefox Monitor homepage is loaded.

[Regression]:

  • I don't think this is a regression.

[Notes]:

  • Considering the fact that these emails are already being monitored, there should be a way to notify people that their email is already unsubscribed to this service.
@groovecoder groovecoder self-assigned this Sep 6, 2018
@groovecoder
Copy link
Member

@groovecoder groovecoder commented Sep 6, 2018

I'll most likely fix this and #353 together so I'm assigning this to myself.

@mheubusch
Copy link

@mheubusch mheubusch commented Sep 10, 2018

Recommended string: This email address is not subscribed to Firefox Monitor.

groovecoder added a commit that referenced this issue Sep 10, 2018
fix #364: show error when unsubscribe token isn't found
@CiprianGeorgiu
Copy link

@CiprianGeorgiu CiprianGeorgiu commented Sep 12, 2018

Verified fixed on 62.0, under macOS 10.13, Ubuntu 16.04 x64 and Windows 10 x64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants