Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The breach <number> is not bolded when displaying results on the page #786

Closed
GeorgiuCiprian opened this issue Feb 19, 2019 · 2 comments
Closed

Comments

@GeorgiuCiprian
Copy link
Collaborator

@GeorgiuCiprian GeorgiuCiprian commented Feb 19, 2019

[Affected versions]:

  • Firefox 65.0.1

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.13
  • Ubuntu 18.04 x64

[Steps to reproduce]:

  1. Navigate to http://stage.firefoxmonitor.nonprod.cloudops.mozgcp.net
  2. Scan a compromised account, e.g. test@gmail.com.

[Expected result]:

  • The of compromised accounts is displayed with a bold style.

[Actual result]:

  • The of compromised accounts has a normal style not bolded.

[Regression]:

  • N/A

[Additional notes]:

  • please observe the screenshot with the issue below:

bold2

@pdehaan
Copy link
Collaborator

@pdehaan pdehaan commented Feb 20, 2019

One thing I did notice today is that "zero" is not bold if you magically weren't involved in a breach. Not sure if that's worth a follow up bug or if it's "good enough"(tm) for now.

via https://fx-breach-alerts.herokuapp.com/scan

{
  commit: "f5c4b5e88e1df37b19125eff19b2fea0bf497ea8",
  version: "f5c4b5e88e1df37b19125eff19b2fea0bf497ea8",
  source: "https://github.com/mozilla/blurts-server"
}

firefox_monitor___scan_results

firefox_monitor___scan_results

@GeorgiuCiprian
Copy link
Collaborator Author

@GeorgiuCiprian GeorgiuCiprian commented Feb 28, 2019

I can confirm that the compromised number has a bold style on stage. Tested with 67.0a1 under Windows 10 x64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants