Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bouncer tests #25

Merged
merged 1 commit into from

6 participants

@brandonsavage

No description provided.

@retornam retornam was assigned
@AlinT AlinT commented on the diff
tests/test_redirects.py
((19 lines not shown))
+
+ def test_redirect_special_for_win8_os(self, testsetup):
+ url = testsetup.base_url
+ param = {
+ 'product': 'firefox-19.0',
+ 'os': 'win',
+ 'lang': 'en-US',
+ }
+
+ user_agent_string = 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0)';
+
+ response = self._head_request(url, params=param, user_agent = user_agent_string)
+
+ parsed_url = urlparse(response.url)
+
+ Assert.true('19.0.1' in parsed_url.path, 'Redirect failed using params of %s' % (parsed_url.path))
@AlinT
AlinT added a note

This test fails for me: http://pastebin.mozilla.org/2186139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bobsilverberg

I get the same failure as @AlinT

@bobsilverberg

This passes on stage but fails on prod.

@stephendonner

We aim to ship in about an hour, just FYI, so the test will pass then.

@brandonsavage

Good. The tests SHOULD fail on prod but pass on stage. When we release, they should pass on both. That's how we'll verify the release.

@bobsilverberg

So do we want to merge now, and wait for the test to start passing on prod, or wait for prod to start failing and then merge to fix the failure?

@brandonsavage
@zacc zacc merged commit b669c59 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 32 additions and 0 deletions.
  1. +32 −0 tests/test_redirects.py
View
32 tests/test_redirects.py
@@ -116,3 +116,35 @@ def test_redirect_for_firefox_aliases(self, testsetup, product_alias):
product_alias['product_name'] != 'firefox-latest-euballot'
):
Assert.contains('/%s/' % 'win32', parsed_url.path)
+
+ def test_redirect_for_windows_to_version19(self, testsetup):
+ url = testsetup.base_url
+ param = {
+ 'product': 'firefox-19.0',
+ 'os': 'win',
+ 'lang': 'en-US',
+ }
+
+ response = self._head_request(url, params=param)
+
+ parsed_url = urlparse(response.url)
+
+ Assert.true('19.0' in parsed_url.path, 'Redirect failed using params of %s' % (parsed_url.path))
+
+
+ def test_redirect_special_for_win8_os(self, testsetup):
+ url = testsetup.base_url
+ param = {
+ 'product': 'firefox-19.0',
+ 'os': 'win',
+ 'lang': 'en-US',
+ }
+
+ user_agent_string = 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0)';
+
+ response = self._head_request(url, params=param, user_agent = user_agent_string)
+
+ parsed_url = urlparse(response.url)
+
+ Assert.true('19.0.1' in parsed_url.path, 'Redirect failed using params of %s' % (parsed_url.path))
@AlinT
AlinT added a note

This test fails for me: http://pastebin.mozilla.org/2186139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+
Something went wrong with that request. Please try again.