Bouncer tests #25

Merged
merged 1 commit into from Mar 1, 2013

Conversation

Projects
None yet
6 participants
Contributor

brandonsavage commented Mar 1, 2013

No description provided.

retornam was assigned Mar 1, 2013

@AlinT AlinT commented on the diff Mar 1, 2013

tests/test_redirects.py
+
+ def test_redirect_special_for_win8_os(self, testsetup):
+ url = testsetup.base_url
+ param = {
+ 'product': 'firefox-19.0',
+ 'os': 'win',
+ 'lang': 'en-US',
+ }
+
+ user_agent_string = 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0)';
+
+ response = self._head_request(url, params=param, user_agent = user_agent_string)
+
+ parsed_url = urlparse(response.url)
+
+ Assert.true('19.0.1' in parsed_url.path, 'Redirect failed using params of %s' % (parsed_url.path))
@AlinT

AlinT Mar 1, 2013

Contributor

This test fails for me: http://pastebin.mozilla.org/2186139

Collaborator

bobsilverberg commented Mar 1, 2013

I get the same failure as @AlinT

Collaborator

bobsilverberg commented Mar 1, 2013

This passes on stage but fails on prod.

Collaborator

stephendonner commented Mar 1, 2013

We aim to ship in about an hour, just FYI, so the test will pass then.

Contributor

brandonsavage commented Mar 1, 2013

Good. The tests SHOULD fail on prod but pass on stage. When we release, they should pass on both. That's how we'll verify the release.

Collaborator

bobsilverberg commented Mar 1, 2013

So do we want to merge now, and wait for the test to start passing on prod, or wait for prod to start failing and then merge to fix the failure?

Contributor

brandonsavage commented Mar 1, 2013

Probably best to merge now.

On Mar 1, 2013, at 10:48 AM, Bob Silverberg notifications@github.com wrote:

So do we want to merge now, and wait for the test to start passing on prod, or wait for prod to start failing and then merge to fix the failure?


Reply to this email directly or view it on GitHub.

@zacc zacc pushed a commit that referenced this pull request Mar 1, 2013

Zac Merge pull request #25 from brandonsavage/master
Bouncer tests
b669c59

@zacc zacc merged commit b669c59 into mozilla:master Mar 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment