Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixing test to add response headers and response.url #32

Merged
merged 1 commit into from Apr 11, 2013

Conversation

Projects
None yet
3 participants
Member

retornam commented Apr 10, 2013

No description provided.

Collaborator

stephendonner commented Apr 10, 2013

Thx - can you print out what it'll look like with the current run, which fails? Does it match the output from the other tests, which @bobsilverberg fixed in #29 ?

Member

retornam commented Apr 10, 2013

@brandonsavage on stage the query params are blank. dev works though

@m8ttyB m8ttyB commented on an outdated diff Apr 11, 2013

tests/test_redirects.py
@@ -140,4 +140,6 @@ def test_redirect_for_windows_200_to_2001(self, testsetup):
parsed_url = urlparse(response.url)
- Assert.true('20.0.1' in parsed_url.query, 'Redirect failed using params of %s' % (parsed_url.query))
+ Assert.contains('20.0.1', response.url,
+ '\n %s' % self.response_info(response))
@m8ttyB

m8ttyB Apr 11, 2013

Collaborator

To be pep8 compliant you should indent the line a bit more - also it appears that you used tabs instead of spaces

Member

retornam commented Apr 11, 2013

@m8ttyB retornam/bouncer-tests@69f159f has fixes for the whole file.

Collaborator

m8ttyB commented Apr 11, 2013

Nice! Merging

@m8ttyB m8ttyB added a commit that referenced this pull request Apr 11, 2013

@m8ttyB m8ttyB Merge pull request #32 from retornam/devfix
 fixing test to add response headers and response.url
7ea1382

@m8ttyB m8ttyB merged commit 7ea1382 into mozilla:master Apr 11, 2013

@retornam retornam deleted the retornam:devfix branch Apr 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment