Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Add support for win64 and linux64, part of Bug 1229852 #75

Merged
merged 2 commits into from Dec 4, 2015
Merged

Add support for win64 and linux64, part of Bug 1229852 #75

merged 2 commits into from Dec 4, 2015

Conversation

kyoshino
Copy link
Contributor

@kyoshino kyoshino commented Dec 3, 2015

We are adding win64 builds to https://www.mozilla.org/en-US/firefox/all/ (mozilla/bedrock#3630). This PR adds win64 and linux64 to the tests.

@kyoshino
Copy link
Contributor Author

kyoshino commented Dec 3, 2015

@davehunt r?

@kyoshino kyoshino changed the title Bug 1181014 - Make Firefox 40 win64 builds on the Release channel available on mozilla.org Bug 1229852 - Make Firefox 40 win64 builds on the Release channel available on mozilla.org Dec 3, 2015
@m8ttyB
Copy link
Contributor

m8ttyB commented Dec 4, 2015

r+, this looks correct as well as the tests run and pass against prod and stage.

That said, I'm hesitant to merge this at the moment. @kyoshino noted that the tests don't run and pass in his environment. @kyoshino Let's hold off merging until you're able to get the tests to pass as well.

@kyoshino
Copy link
Contributor Author

kyoshino commented Dec 4, 2015

I've found a solution for the failing tests. Updated setup.cfg to ignore tests under venv.

[pytest]
norecursedirs = venv

That's it!

@m8ttyB
Copy link
Contributor

m8ttyB commented Dec 4, 2015

Does py.test --baseurl="http://download.mozilla.org" tests/ produce similar results?

@kyoshino
Copy link
Contributor Author

kyoshino commented Dec 4, 2015

@m8ttyB That's the same thing, all tests under venv are ignored. I'm updating README to clarify the command.

@m8ttyB
Copy link
Contributor

m8ttyB commented Dec 4, 2015

Merging.

emma-stone-excited

m8ttyB pushed a commit that referenced this pull request Dec 4, 2015
Bug 1229852 - Make Firefox 40 win64 builds on the Release channel available on mozilla.org
@m8ttyB m8ttyB merged commit 457790e into mozilla:master Dec 4, 2015
@kyoshino
Copy link
Contributor Author

kyoshino commented Dec 4, 2015

\o/ \o/ \o/

@kyoshino kyoshino deleted the bug-1181014-win64 branch December 4, 2015 00:19
@kyoshino kyoshino changed the title Bug 1229852 - Make Firefox 40 win64 builds on the Release channel available on mozilla.org Support win64 and linux64, part of Bug 1229852 Dec 14, 2015
@kyoshino kyoshino changed the title Support win64 and linux64, part of Bug 1229852 Add support for win64 and linux64, part of Bug 1229852 Dec 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants