New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to download individual file or folder structure without having to download the whole project. #596

Closed
sdalmeida opened this Issue Feb 17, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@sdalmeida

sdalmeida commented Feb 17, 2017

Feature first filed here mozilla/thimble.mozilla.org#1313 by @ScottDowne

It would be amazing if brackets had an option to download individual file or folder structure without having to download the whole project.

Here are the behaviors for this new feature:

Downloading a Single file

UI:
download_file
Expected behavior: The selected file will be downloaded without it being zipped.

Downloading a Folder

UI:
download_folder
Expected behavior: This will zip the folder structure/contents and download it. The contents in the zip file will look like this: { folder name } / { file contents }

If the folder is empty and the user chooses to download it, should an error message show or should the empty folder be zipped and downloaded? What do you think?

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Feb 17, 2017

Member

I'd recommend you make the context-menu string just say "Download" and then you don't need to figure out if its a file or folder in the UI.

I'd then consider reworking this function https://github.com/mozilla/brackets/blob/master/src/filesystem/impls/filer/ArchiveUtils.js#L145 so that you can pass a path instead of having it assume you want to zip the project root. It should just "Do the Right Thing" if you pass it a file or folder.

I'm assuming you want to work on this, but let me know if I'm wrong.

Member

humphd commented Feb 17, 2017

I'd recommend you make the context-menu string just say "Download" and then you don't need to figure out if its a file or folder in the UI.

I'd then consider reworking this function https://github.com/mozilla/brackets/blob/master/src/filesystem/impls/filer/ArchiveUtils.js#L145 so that you can pass a path instead of having it assume you want to zip the project root. It should just "Do the Right Thing" if you pass it a file or folder.

I'm assuming you want to work on this, but let me know if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment