Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #631: Implements Thimble Console Back End. #624
This is starting to take shape. In addition to the fixes I've mentioned here, we'll also need to expand this a bit before we go further. I'd like to get a proper set of wrappers for all the various
console.* methods. We can use some of the example implementations I've sent you in the issue (e.g., firebug-lite) as a guide.
changed the title from
Implements Thimble Console Log Back End.
Fixes #631: Implements Thimble Console Back End.
Mar 15, 2017
@humphd, @Pomax the code is ready for another look over. I fixed the syntax issue which caused Travis to fail, and also simplified where I could at @Pomax's request. Included below is how the console currently functions and how I tested said console functions.
If we are content with the code changes, I'd be welcome to closing both this and the issue #631 and creating a new issue related to the UI of the console.
@humphd, Thank you for the code review. I will get to these changes immediately. When I am done, would you like me to branch off while this one awaits code review and work on the Console UI? Or, commit to here?
PS, thank you for clarifying some of the syntactical issues I had previously, I do appreciate learning the most optimal way for Mozilla-esque development and concerns.
The thing with
Don't push any more new code to this branch, do all new stuff (except for fixes) on new PRs and branches.
Few small things, and I think this is ready! Let me know what you've fixed these.