Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mozilla/thimble.mozilla.org#2515: QuickEdit Lightning indicator now disappears when switching to Font Viewer #887

Merged

Conversation

exspherience
Copy link

Fix for mozilla/thimble.mozilla.org#2515

When switching to the Font Viewer while adding/editing a CSS color rule, the indicator should now disappear.

Before:
bug2515before

After:
bug2515fixed

Copy link

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, code is perfect.

I'll get @flukeout to do a functional test to make sure he's happy.

r+ from me, great work!

@humphd humphd requested a review from flukeout October 17, 2017 18:08
@flukeout
Copy link

Testing now!

@flukeout
Copy link

Beautiful font choice there with Chancery @ddinis-alves - nice. Tested this and the bug is gone, nice work and thank you 👍

@flukeout flukeout merged commit c89322d into mozilla:master Oct 17, 2017
@exspherience exspherience deleted the QuickEdit-doesnt-disappear-on-Font-Viewer branch October 17, 2017 21:58
gideonthomas pushed a commit that referenced this pull request Nov 17, 2017
…ow disappears when switching to Font Viewer (#887)

* Fixing QuickEdit Indicator does not disappear when Switching to Font Viewer

* Fixing QuickEdit Indicator does not disappear when Switching to Font Viewer

* Fixing QuickEdit Indicator does not disappear when Switching to Font Viewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants