Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2554 Updated remaining uses of Courier to Courier New #896

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@marcobeltempo
Copy link

@marcobeltempo marcobeltempo commented Nov 24, 2017

Fixes mozilla/thimble.mozilla.org#2554

  • Added Courier new to remaining uses of courier.

Read this issue for more info
mozilla/thimble.mozilla.org#2552

@humphd humphd requested a review from flukeout Nov 27, 2017
@humphd
Copy link
Member

@humphd humphd commented Nov 27, 2017

Adding @flukeout for review on this.

@flukeout
Copy link

@flukeout flukeout commented Dec 1, 2017

Awsome, thank you! Left a small comment about indentation in one of the stylesheets.

@@ -47,6 +46,10 @@ body {
background-repeat: no-repeat;
}

#PDFBug .stats {
font-family: "Courier New", Courier, monospace !important;
Copy link

@flukeout flukeout Dec 1, 2017

Small nit, could you please indent this line to match the rest of the stylesheet?

Copy link
Author

@marcobeltempo marcobeltempo Dec 4, 2017

Ahhh good eye @flukeout Just fixed it

@humphd humphd requested a review from flukeout Dec 4, 2017
@humphd
Copy link
Member

@humphd humphd commented Dec 4, 2017

Re-flagging @flukeout for a followup review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants