Navigation Menu

Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Should be able to hit enter to start verifying a primary email #946

Closed
Mardak opened this issue Jan 24, 2012 · 8 comments
Closed

Should be able to hit enter to start verifying a primary email #946

Mardak opened this issue Jan 24, 2012 · 8 comments

Comments

@Mardak
Copy link
Member

Mardak commented Jan 24, 2012

Right now, nothing happens when hitting enter on "Verify With Email Provider" dialog.

@jbonacci
Copy link
Contributor

@Mardak can you provide some details and possibly a screen shot for QA and Dev to debug?

@Mardak
Copy link
Member Author

Mardak commented Jan 24, 2012

Enter "ed@eyedee.me" for an email address and hit enter. The next dialog to appear should be "Verify With Email Provider" and hitting enter does nothing.

@jbonacci
Copy link
Contributor

I start at diresworb.org and click Sign In.
I enter jbonacci@eyedee.me from the Primary.
The next message is "To verify that you own jbonacci@eyedee.me, you must sign in with your provider. A new window will be opened. " with a Verify button.
I click the Verify button.
I get an eyedee.me pop-up: https://eyedee.me/browserid/sign_in.html?email=blah....
I enter my password and click Sign In.
I am signed into Direswrob.org
I sign out.

Trying again from beta.myfavoritebeer.org
And, I am automatically signed in.

@jbonacci
Copy link
Contributor

This time I am starting with an email that I have never used from the Primary.
jbonacci2@eyedee.me.
Sign In at beta.myfavoritebeer.org with that email
I get this message:
"Verify With Email Provider
To verify that you own jbonacci2@eyedee.me, you must sign in with your provider. This window will be redirected to
https://eyedee.me/browserid/sign_in.html. "
and a Verify button.
I click the Verify button.
And I get an eyedee.me pop-up that says:
"Sorry, jbonacci2@eyedee.me is not a known user! You can create such a user right now, just pick a password: "
Entered a password and clicked on Create My Account
Address was verified and I am signed into the beer site.

@jrgm
Copy link
Contributor

jrgm commented Jan 24, 2012

@markdak you mean that the 'verify' button should be focused in that dialog (so hitting Enter is the same as clicking
on that button). Right?

@jbonacci
Copy link
Contributor

OK, well my bad if that is the real issue here.
The current (non-primary) path through the UI seems to work with hitting Enter at each step because focus has been put on the "default next thing to do" link or button.

My confusion lies in the fact they we have been entering several issues that have more to do with "I have selected the next course of action but nothing is happening", i.e. network latency, server issues, broken links, etc.

Damn good catch. Thanks, @Mardak

@jrgm
Copy link
Contributor

jrgm commented Feb 8, 2012

Okay, verified on win7/winxp/osx/ubuntu (android moot). This flow (apart from having to click sign in on e.g., myfavoritebeer.org) is navigable with the keyboard.

@jrgm
Copy link
Contributor

jrgm commented Feb 10, 2012

Note to @Mardak: this fix will be in production next week sometime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants