Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

scroll bar appears in required email flow when verifying with primary #947

Closed
shane-tomlinson opened this issue Jan 24, 2012 · 4 comments
Closed

scroll bar appears in required email flow when verifying with primary #947

shane-tomlinson opened this issue Jan 24, 2012 · 4 comments
Assignees
@shane-tomlinson
Labels
qa:needs testcase qa:verified ★★★★★

Comments

@shane-tomlinson
Copy link

Steps to reproduce:

  1. Open dev.myfavoriteshow.org
  2. Enter in a "primary" supported email address - something at eyedee.me
  3. Check out the scroll bar.

Check out screen shot:
https://skitch.com/set117/g5882/browser-id
@ghost ghost assigned shane-tomlinson Jan 24, 2012
@shane-tomlinson
Copy link
Author

Labeling 5 star though it is a new feature just because it is such an ugly ugly user facing blemish on an otherwise awesome feature.

shane-tomlinson pushed a commit that referenced this issue Jan 24, 2012
Fix scrollbar showing in the Required Email screen if email is a prim…
4ba1ea1 
…ary.

Set the max-height to 130px instead of 110px.

issue #947
@shane-tomlinson shane-tomlinson mentioned this issue Jan 24, 2012
Closed
shane-tomlinson pushed a commit that referenced this issue Jan 24, 2012
@lloyd
Fix scrollbar showing in the Required Email screen if email is a prim…
161e304 
…ary.

Set the max-height to 130px instead of 110px.

issue #947
@lloyd
Copy link
Contributor

lloyd commented Jan 24, 2012

hotfixed in 2012.12.18.02

@lloyd lloyd closed this as completed Jan 24, 2012
@shane-tomlinson
Copy link
Author

This is back with longish email addresses.

https://skitch.com/set117/g7say/verify-required-primary

fetep pushed a commit to fetep/browserid that referenced this issue Feb 3, 2012
@ozten
Remove the scroll bar showing in required email flow with primary email.
c896354 
close mozilla#947
@jrgm
Copy link
Contributor

jrgm commented Feb 8, 2012

verified on stage for multiple browser/os including android 2.1 stock.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shane-tomlinson shane-tomlinson

Labels
qa:needs testcase qa:verified ★★★★★
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lloyd @jrgm @shane-tomlinson