Skip to content
This repository was archived by the owner on May 10, 2019. It is now read-only.

Fix the spinner (main site and it's wonkiness)#3395

Merged
jedp merged 3 commits into
devfrom
issue_3394_main_site_spinner
May 15, 2013
Merged

Fix the spinner (main site and it's wonkiness)#3395
jedp merged 3 commits into
devfrom
issue_3394_main_site_spinner

Conversation

@shane-tomlinson

Copy link
Copy Markdown

@jedp - could I get a quick review?

@jrgm - should we merge this into train-2013.05.08 as well?

fixes #3394

@ghost ghost assigned jedp May 15, 2013
* Reduces the "wobble"
* Inlines the image for performance

fixes #3404
fixes #3349
@shane-tomlinson

Copy link
Copy Markdown
Author

@jedp - An ephemeral instance is already set up for testing purposes - spinner.personatest.org.

@jedp

jedp commented May 15, 2013

Copy link
Copy Markdown
Contributor

trying on a v1.0.1 unagi ...

@jedp

jedp commented May 15, 2013

Copy link
Copy Markdown
Contributor

I like this a lot. I like the spinner smaller, and it certainly looks centered on device. r=me.

jedp added a commit that referenced this pull request May 15, 2013
Fix the spinner (main site and it's wonkiness)
@jedp jedp merged commit 094f549 into dev May 15, 2013
@shane-tomlinson

Copy link
Copy Markdown
Author

Jed just informed me that we can allow this to go into dev to make its way to prod in time. It doesn't look like we need to hotfix stage.

@shane-tomlinson shane-tomlinson deleted the issue_3394_main_site_spinner branch May 15, 2013 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants