Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[duplicate_copy_metadata] Cannot copy the cf_performance_impact field #1990

Closed
suhaibmujahid opened this issue Apr 19, 2023 · 4 comments
Closed
Assignees
Labels

Comments

@suhaibmujahid
Copy link
Member

2023-04-19 08:32:34,827 - ERROR - duplicate_copy_metadata: Cannot put data for bug 1421562 (change => {'cf_performance_impact': 'low', 'comment': {'body': 'The following field has been copied from a duplicate bug:\n\n| Field | Value | Source |\n| ----- | ----- | ------ |\n| Performance Impact | low | bug 1456615 |\n\n\nFor more information, please visit [auto_nag documentation](https://wiki.mozilla.org/Release_Management/autonag#duplicate_copy_metadata.py).'}}): ['1421562']
2023-04-19 08:32:39,083 - ERROR - duplicate_copy_metadata: Cannot put data for bug 1363131 (change => {'cf_performance_impact': 'medium', 'comment': {'body': 'The following field has been copied from a duplicate bug:\n\n| Field | Value | Source |\n| ----- | ----- | ------ |\n| Performance Impact | medium | bug 1383758 |\n\n\nFor more information, please visit [auto_nag documentation](https://wiki.mozilla.org/Release_Management/autonag#duplicate_copy_metadata.py).'}}): ['1363131']
@marco-c
Copy link
Contributor

marco-c commented Apr 19, 2023

Is it possible that the bot doesn't have permissions to set this field?

@suhaibmujahid
Copy link
Member Author

suhaibmujahid commented Apr 19, 2023

Is it possible that the bot doesn't have permissions to set this field?

Yes, this is the reason:

{
    "error": true,
    "message": "You tried to change the Performance Impact field from --- to low , but only a user with the required permissions may change that field. Additonal information:Specific permissions are required to make this change If you are attempting to confirm an unconfirmed bug or edit the fields of a bug, find out how to get the necessary permissions.",
    "documentation": "https://bmo.readthedocs.io/en/latest/api/",
    "code": 115
}

@davehunt is it ok for the bot to copy the Performance Impact field from the duplicate bugs? Or should the bot set the field to ? in such cases?

Example bug 1421562:

The following field has been copied from a duplicate bug:

Field Value Source
Performance Impact low bug 1456615

For more information, please visit auto_nag documentation.

Example bug 1363131:

The following field has been copied from a duplicate bug:

Field Value Source
Performance Impact medium bug 1383758

For more information, please visit auto_nag documentation.

@suhaibmujahid
Copy link
Member Author

From @davehunt on Slack:

I think it makes sense to grant the bot permission.

@suhaibmujahid
Copy link
Member Author

suhaibmujahid commented Apr 19, 2023

From @dklawren on Slack:

They need to be in the perf-triage-team permission group. I will add them now.

@suhaibmujahid suhaibmujahid self-assigned this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants