Skip to content

Clarify error message for private Phabricator revisions #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
padenot wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −2
Open

Clarify error message for private Phabricator revisions #6138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ea047
mcp: clear error message for private Phabricator revisions
padenot Jun 8, 2026
af55d7e
mcp: use is_accessible/is_public for private revision check
padenot Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions services/mcp/src/bugbug_mcp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,20 +139,29 @@ def bughandler(bug):
return result


def _get_revision_md(revision_id: int) -> str:
patch = SanitizedPhabricatorPatch(revision_id=revision_id)
if not patch.is_accessible() or not patch.is_public():
raise ToolError(
f"Revision D{revision_id} was not found. It may not exist or may be private."
)
return patch.to_md()


@mcp.resource(
uri="phabricator://revision/D{revision_id}",
name="Phabricator Revision Content",
mime_type="text/markdown",
)
def handle_revision_view_resource(revision_id: int) -> str:
"""Retrieve a revision from Phabricator alongside its comments."""
return SanitizedPhabricatorPatch(revision_id=revision_id).to_md()
return _get_revision_md(revision_id)


@mcp.tool()
def get_phabricator_revision(revision_id: int) -> str:
"""Retrieve a revision from Phabricator alongside its comments."""
return SanitizedPhabricatorPatch(revision_id=revision_id).to_md()
return _get_revision_md(revision_id)


llms_txt = FileResource(
Expand Down