Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-LDAP login issue #114

Merged
merged 8 commits into from Jun 13, 2019
Merged

Non-LDAP login issue #114

merged 8 commits into from Jun 13, 2019

Conversation

shilpaexaltcg
Copy link
Contributor

No description provided.

TrangNguyenBC and others added 2 commits June 12, 2019 17:17
Fixed nonLDAP user login issue by changing code to previous commit
@sylvestre
Copy link
Collaborator

Thanks for fixing the ownership issue
However, you didn't fix when the ldap access is used. I am getting:

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

#80 (comment)

- Created a new getFakeReportees file for nonldap login
- Added condition to check the type of login
- added new value to usersesstion to identify the type of login and using the new value for user login
Added console.log for debugging purpose
src/views/Main/index.jsx Outdated Show resolved Hide resolved
src/views/Main/index.jsx Outdated Show resolved Hide resolved
@sylvestre sylvestre merged commit 397b623 into mozilla:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants