Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always 403 on permission fail if logged out. #85

Merged
merged 1 commit into from Jun 18, 2014

Conversation

@IanConnolly
Copy link
Contributor

IanConnolly commented Jun 18, 2014

Right now we're just doing an abort(403) on a permission check fail, even if the user is logged out. We should really prompt the user to log in before deciding they don't have permission.

@Callek
Copy link
Contributor

Callek commented Jun 18, 2014

Well this looks pretty good to me, @petemoore @djmitche if either of you also like this, I'll happily merge it in for Ian!

@djmitche
Copy link
Contributor

djmitche commented Jun 18, 2014

Wow, very simple - yes, @Callek merge away.

@moz-v2v-gh moz-v2v-gh merged commit ab55f09 into mozilla:master Jun 18, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Callek added a commit that referenced this pull request Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.