Don't always 403 on permission fail if logged out. #85

Merged
merged 1 commit into from Jun 18, 2014

Conversation

Projects
None yet
4 participants
@IanConnolly
Contributor

IanConnolly commented Jun 18, 2014

Right now we're just doing an abort(403) on a permission check fail, even if the user is logged out. We should really prompt the user to log in before deciding they don't have permission.

@Callek

This comment has been minimized.

Show comment
Hide comment
@Callek

Callek Jun 18, 2014

Contributor

Well this looks pretty good to me, @petemoore @djmitche if either of you also like this, I'll happily merge it in for Ian!

Contributor

Callek commented Jun 18, 2014

Well this looks pretty good to me, @petemoore @djmitche if either of you also like this, I'll happily merge it in for Ian!

@djmitche

This comment has been minimized.

Show comment
Hide comment
@djmitche

djmitche Jun 18, 2014

Contributor

Wow, very simple - yes, @Callek merge away.

Contributor

djmitche commented Jun 18, 2014

Wow, very simple - yes, @Callek merge away.

@moz-v2v-gh moz-v2v-gh merged commit ab55f09 into mozilla:master Jun 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

Callek added a commit that referenced this pull request Jun 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment