From 6dbf11c809dd778079d293796c22149932fbf32a Mon Sep 17 00:00:00 2001 From: Justin Wood Date: Tue, 15 Jan 2013 08:56:39 -0500 Subject: [PATCH] Bug 830316 - Print failures at the end of manage_masters.py - always. r=bhearsum --HG-- extra : rebase_source : 8d910c887c9dbe1936592ec8669680f87a86a64b --- buildfarm/maintenance/manage_masters.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/buildfarm/maintenance/manage_masters.py b/buildfarm/maintenance/manage_masters.py index a4aa1bcbd..227cc486a 100755 --- a/buildfarm/maintenance/manage_masters.py +++ b/buildfarm/maintenance/manage_masters.py @@ -12,9 +12,10 @@ import util.fabric.actions def print_status(remaining, failed_masters): - print "=" * 30, "Remaining masters", "=" * 30 - for m in remaining: - print m + if remaining: + print "=" * 30, "Remaining masters", "=" * 30 + for m in remaining: + print m if failed_masters: print "=" * 30, "failed masters", "=" * 30 for m in failed_masters: @@ -158,5 +159,8 @@ def run_action_on_master(action, master): time.sleep(1) p.join() + # One final print before we exit, to be sure that results are not missed + print_status([m['name'] for (m, r) in results], + failed_masters) if failed: sys.exit(1)