This repository has been archived by the owner. It is now read-only.

T38editors #122

Merged
merged 1 commit into from May 1, 2012

Conversation

Projects
None yet
2 participants
@ScottDowne
Contributor

ScottDowne commented Mar 28, 2012

No description provided.

@humphd

View changes

editors/googlemap-editor.html
+ elements.lng.value = trackEvent.lng;
+
+ marker.setPosition(loc);
+ //marker.setTitle(trackEvent.label);

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

This is a bad idea, why leave commented code in? File a new bug to add it later.

@humphd

humphd Mar 28, 2012

Member

This is a bad idea, why leave commented code in? File a new bug to add it later.

@humphd

View changes

editors/googlemap-editor.html
+
+ geocoder.geocode( { address: location },
+ function(results, status) {
+ if (status == gmaps.GeocoderStatus.OK) {

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

s/==/===/

@humphd

humphd Mar 28, 2012

Member

s/==/===/

@humphd

View changes

editors/googlemap-editor.html
+
+ if (isNaN(value) ||
+ value < 0
+ //todo: || value > duration

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

This is a way better style for leaving crap in. Worth more if it has a bug number with it, as in //todo (see #xxx)

@humphd

humphd Mar 28, 2012

Member

This is a way better style for leaving crap in. Worth more if it has a bug number with it, as in //todo (see #xxx)

This comment has been minimized.

Show comment Hide comment
@ScottDowne

ScottDowne Mar 28, 2012

Contributor

Not my code.

I think the reason it was commented out, and not implemented, is because there is no way to get the duration at this point.

I am fine with checking for value != null.

@ScottDowne

ScottDowne Mar 28, 2012

Contributor

Not my code.

I think the reason it was commented out, and not implemented, is because there is no way to get the duration at this point.

I am fine with checking for value != null.

@humphd

View changes

editors/googlemap-editor.html
+
+ trackEvent[id] = value;
+
+ //todo: if element does not have focus, update element.value

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

same deal.

@humphd

humphd Mar 28, 2012

Member

same deal.

@humphd

View changes

editors/googlemap-editor.html
+ trackEvent.lng !== undefined &&
+ !isNaN(trackEvent.lng) &&
+ trackEvent.lat < -90 && trackEvent.lat > 90 &&
+ trackEvent.lng < -180 && trackEvent.lng > 180

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

indent this block so it's under trackEvent in line 283 vs. aligned with body of the block beneath.

@humphd

humphd Mar 28, 2012

Member

indent this block so it's under trackEvent in line 283 vs. aligned with body of the block beneath.

@humphd

View changes

editors/googlemap-editor.html
+ } else if (trackEvent.location) {
+ geocode(trackEvent.location);
+ } else {
+ latLng = new gmaps.LatLng(37.09024, -95.712891);

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

magic numbers?

@humphd

humphd Mar 28, 2012

Member

magic numbers?

+ marker.setVisible(true);
+ }
+
+ if (map && trackEvent.zoom != null) {

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

!==

This comment has been minimized.

Show comment Hide comment
@ScottDowne

ScottDowne Mar 28, 2012

Contributor

This one was mine, and not Brian's, and this was intended to check for numeric values. 0 will be true in this case.

@ScottDowne

ScottDowne Mar 28, 2012

Contributor

This one was mine, and not Brian's, and this was intended to check for numeric values. 0 will be true in this case.

@humphd

View changes

src/core/comm.js
- _this.dispatch( "error", {
- type: "connectionclosed"
- });
+ //_this.dispatch( "error", {

This comment has been minimized.

Show comment Hide comment
@humphd

humphd Mar 28, 2012

Member

don't leave commented code.

@humphd

humphd Mar 28, 2012

Member

don't leave commented code.

@ScottDowne ScottDowne merged commit f7ffad1 into mozilla:master May 1, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.