Skip to content

Loading…

T1828 #662

Merged
merged 3 commits into from

4 participants

@mjschranz
Mozilla member

/botio try

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/ddf7ea937843e08/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/ddf7ea937843e08/output.txt

Total script time: 1.42 mins

Your job has been submitted to the swarm! see http://norway.proximity.on.ca/user/butter

@humphd humphd commented on an outdated diff
src/core/popcorn-wrapper.js
@@ -32,7 +32,8 @@ define( [ "core/logger", "core/eventmanager", "util/uri" ], function( Logger, Ev
_mediaType,
_butterEventMap = {},
_interruptLoad = false,
- _this = this;
+ _this = this,
+ _appendUID = options.appendUID !== undefined ? options.appendUID : true;
@humphd Mozilla member
humphd added a note

default-config.json should include this property, with a default set (probably true). That way you don't have to do this dance, since a config will always have an appendUID option. Also, in the config, I'd rename the property, since this makes no sense unless you really understand our code. Maybe use makeVideoURLsUnique or something else more descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@humphd
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @humphd received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/043a0c992d9dd84/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/043a0c992d9dd84/output.txt

Total script time: 1.06 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio cleanup

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/5941fa880b8abe1/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/5941fa880b8abe1/output.txt

Total script time: 0.74 mins

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/941a0f33d744fa4/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/941a0f33d744fa4/output.txt

Total script time: 0.89 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio cleanup

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/991f3ec2aea19b2/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/991f3ec2aea19b2/output.txt

Total script time: 0.33 mins

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/e251cb7a0a60651/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/e251cb7a0a60651/output.txt

Total script time: 1.56 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio try

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/eb1b4a68bad19bb/output.txt

@butterbot

From: Bot.io (butyr.org)


Failed

Full output at http://botio.butyr.org:8000/eb1b4a68bad19bb/output.txt

Total script time: 0.20 mins

@mjschranz
Mozilla member

/botio try

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/be48ac5fff7fe1f/output.txt

@butterbot

From: Bot.io (butyr.org)


Failed

Full output at http://botio.butyr.org:8000/be48ac5fff7fe1f/output.txt

Total script time: 2.00 mins

@mjschranz
Mozilla member

/botio try

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/5e5c1072a8160ee/output.txt

@butterbot

From: Bot.io (butyr.org)


Failed

Full output at http://botio.butyr.org:8000/5e5c1072a8160ee/output.txt

Total script time: 2.00 mins

@mjschranz
Mozilla member

/botio check

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_check from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/e3c0f003f2d9987/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/e3c0f003f2d9987/output.txt

Total script time: 0.48 mins

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/39fcb25729b57a1/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/39fcb25729b57a1/output.txt

Total script time: 0.65 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio try

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/3e425015ed44f05/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/3e425015ed44f05/output.txt

Total script time: 1.04 mins

Your job has been submitted to the swarm! see http://norway.proximity.on.ca/user/butter

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/c41a722f20fc05e/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/c41a722f20fc05e/output.txt

Total script time: 0.91 mins

Server is running on http://pr662.butyr.org/templates/test.html

@humphd humphd commented on an outdated diff
test/butter.testrunner.js
((4 lines not shown))
+ function createFrame( testPath ) {
+ // Finish test suite; display totals
+ if ( !firstTest ) {
+ testFrame.parentNode.removeChild( testFrame );
+ }
+ else {
+ firstTest = false;
+ }
+ testFrame = document.createElement( "iframe" );
+ testFrame.onload = function() {
+ testFrame.contentWindow.focus();
+ };
+ // Tells the tests within the iframe to take focus
+ testFrame.addEventListener( "load", sendGetFocus, false );
+ testFrame.src = currentTest.path;
+ document.body.appendChild( testFrame );
@humphd Mozilla member
humphd added a note

I seem to recall Opera being picky about stuff being in the DOM before it will load. You might want to flip the order of 133 and 134 so it puts it into the DOM before setting src.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mjschranz
Mozilla member

/botio cleanup

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/d9b2420f2d7456a/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/d9b2420f2d7456a/output.txt

Total script time: 0.22 mins

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/318de5b4dccdd27/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/318de5b4dccdd27/output.txt

Total script time: 1.73 mins

Server is running on http://pr662.butyr.org/templates/test.html

@humphd
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @humphd received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/707fc6eb43187b7/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/707fc6eb43187b7/output.txt

Total script time: 1.83 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/a51d9550f8a84ae/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/a51d9550f8a84ae/output.txt

Total script time: 0.57 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio cleanup

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/6d910fc3d5917a3/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/6d910fc3d5917a3/output.txt

Total script time: 0.38 mins

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/da83b416e2c2b46/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/da83b416e2c2b46/output.txt

Total script time: 1.97 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio cleanup

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/e4803fac78842ba/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/e4803fac78842ba/output.txt

Total script time: 0.29 mins

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/ce2f3d958c44610/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/ce2f3d958c44610/output.txt

Total script time: 0.73 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/784e1a1912e51cd/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/784e1a1912e51cd/output.txt

Total script time: 0.53 mins

Server is running on http://pr662.butyr.org/templates/test.html

@ScottDowne

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @ScottDowne received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/27bb8bec006bb0f/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/27bb8bec006bb0f/output.txt

Total script time: 1.03 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz
Mozilla member

/botio preview

@butterbot

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/a39b0ba8cdfaf87/output.txt

@butterbot

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/a39b0ba8cdfaf87/output.txt

Total script time: 0.79 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz mjschranz merged commit 4bd6619 into mozilla:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.