T1828 #662

Merged
merged 3 commits into from Aug 1, 2012

Projects

None yet

3 participants

@mjschranz

/botio try

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/ddf7ea937843e08/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/ddf7ea937843e08/output.txt

Total script time: 1.42 mins

Your job has been submitted to the swarm! see http://norway.proximity.on.ca/user/butter

@humphd humphd commented on an outdated diff Jul 18, 2012
src/core/popcorn-wrapper.js
@@ -32,7 +32,8 @@ define( [ "core/logger", "core/eventmanager", "util/uri" ], function( Logger, Ev
_mediaType,
_butterEventMap = {},
_interruptLoad = false,
- _this = this;
+ _this = this,
+ _appendUID = options.appendUID !== undefined ? options.appendUID : true;
@humphd
humphd Jul 18, 2012

default-config.json should include this property, with a default set (probably true). That way you don't have to do this dance, since a config will always have an appendUID option. Also, in the config, I'd rename the property, since this makes no sense unless you really understand our code. Maybe use makeVideoURLsUnique or something else more descriptive.

@humphd
Mozilla member

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @humphd received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/043a0c992d9dd84/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/043a0c992d9dd84/output.txt

Total script time: 1.06 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio cleanup

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/5941fa880b8abe1/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/5941fa880b8abe1/output.txt

Total script time: 0.74 mins

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/941a0f33d744fa4/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/941a0f33d744fa4/output.txt

Total script time: 0.89 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio cleanup

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/991f3ec2aea19b2/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/991f3ec2aea19b2/output.txt

Total script time: 0.33 mins

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/e251cb7a0a60651/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/e251cb7a0a60651/output.txt

Total script time: 1.56 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio try

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/eb1b4a68bad19bb/output.txt

@ghost

From: Bot.io (butyr.org)


Failed

Full output at http://botio.butyr.org:8000/eb1b4a68bad19bb/output.txt

Total script time: 0.20 mins

@mjschranz

/botio try

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/be48ac5fff7fe1f/output.txt

@ghost

From: Bot.io (butyr.org)


Failed

Full output at http://botio.butyr.org:8000/be48ac5fff7fe1f/output.txt

Total script time: 2.00 mins

@mjschranz

/botio try

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/5e5c1072a8160ee/output.txt

@ghost

From: Bot.io (butyr.org)


Failed

Full output at http://botio.butyr.org:8000/5e5c1072a8160ee/output.txt

Total script time: 2.00 mins

@mjschranz

/botio check

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_check from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/e3c0f003f2d9987/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/e3c0f003f2d9987/output.txt

Total script time: 0.48 mins

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/39fcb25729b57a1/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/39fcb25729b57a1/output.txt

Total script time: 0.65 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio try

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_try from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/3e425015ed44f05/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/3e425015ed44f05/output.txt

Total script time: 1.04 mins

Your job has been submitted to the swarm! see http://norway.proximity.on.ca/user/butter

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/c41a722f20fc05e/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/c41a722f20fc05e/output.txt

Total script time: 0.91 mins

Server is running on http://pr662.butyr.org/templates/test.html

@humphd humphd commented on an outdated diff Jul 24, 2012
test/butter.testrunner.js
+ function createFrame( testPath ) {
+ // Finish test suite; display totals
+ if ( !firstTest ) {
+ testFrame.parentNode.removeChild( testFrame );
+ }
+ else {
+ firstTest = false;
+ }
+ testFrame = document.createElement( "iframe" );
+ testFrame.onload = function() {
+ testFrame.contentWindow.focus();
+ };
+ // Tells the tests within the iframe to take focus
+ testFrame.addEventListener( "load", sendGetFocus, false );
+ testFrame.src = currentTest.path;
+ document.body.appendChild( testFrame );
@humphd
humphd Jul 24, 2012

I seem to recall Opera being picky about stuff being in the DOM before it will load. You might want to flip the order of 133 and 134 so it puts it into the DOM before setting src.

@mjschranz

/botio cleanup

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/d9b2420f2d7456a/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/d9b2420f2d7456a/output.txt

Total script time: 0.22 mins

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/318de5b4dccdd27/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/318de5b4dccdd27/output.txt

Total script time: 1.73 mins

Server is running on http://pr662.butyr.org/templates/test.html

@humphd
Mozilla member

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @humphd received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/707fc6eb43187b7/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/707fc6eb43187b7/output.txt

Total script time: 1.83 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/a51d9550f8a84ae/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/a51d9550f8a84ae/output.txt

Total script time: 0.57 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio cleanup

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/6d910fc3d5917a3/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/6d910fc3d5917a3/output.txt

Total script time: 0.38 mins

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/da83b416e2c2b46/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/da83b416e2c2b46/output.txt

Total script time: 1.97 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio cleanup

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_cleanup from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/e4803fac78842ba/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/e4803fac78842ba/output.txt

Total script time: 0.29 mins

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/ce2f3d958c44610/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/ce2f3d958c44610/output.txt

Total script time: 0.73 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/784e1a1912e51cd/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/784e1a1912e51cd/output.txt

Total script time: 0.53 mins

Server is running on http://pr662.butyr.org/templates/test.html

@ScottDowne

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @ScottDowne received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/27bb8bec006bb0f/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/27bb8bec006bb0f/output.txt

Total script time: 1.03 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz

/botio preview

@ghost

From: Bot.io (butyr.org)


Received

Command cmd_preview from @mjschranz received. Current queue size: 0

Live output at: http://botio.butyr.org:8000/a39b0ba8cdfaf87/output.txt

@ghost

From: Bot.io (butyr.org)


Success

Full output at http://botio.butyr.org:8000/a39b0ba8cdfaf87/output.txt

Total script time: 0.79 mins

Server is running on http://pr662.butyr.org/templates/test.html

@mjschranz mjschranz merged commit 4bd6619 into mozilla:master Aug 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment