frontend: Support suite & platform filters.

Author: Bastien Abadie

frontend/src/base.html

@@ -106,6 +106,19 @@ <h2>
   <a href="#view=zero&third_party=on&cpp=on&js=on=java=on&rust=on">View the zero coverage report</a>
   &bull;
   <input type="text" name="revision" placeholder="Mercurial revision" value="{{revision}}"></input>
+  &bull;
+  <select name="platform">
+    <option value="all">All platforms</option>
+    {{#platforms}}
+    <option {{#selected}}selected="selected"{{/selected}} value="{{name}}">{{name}}</option>
+    {{/platforms}}
+  </select>
+  <select name="suite">
+    <option value="all">All test suites</option>
+    {{#suites}}
+    <option {{#selected}}selected="selected"{{/selected}} value="{{name}}">{{name}}</option>
+    {{/suites}}
+  </select>
 </script>
 
 <script id="menu_zero" type="x-tmpl-mustache">

frontend/src/common.js

@@ -59,8 +59,9 @@ function cache_set(cache, key, value) {
 }
 
 let path_coverage_cache = {};
-export async function get_path_coverage(path, changeset) {
-  let data = cache_get(path_coverage_cache, `${changeset}_${path}`);
+export async function get_path_coverage(path, changeset, platform, suite) {
+  let cache_key = `${changeset}_${path}_${platform}_${suite}`;
+  let data = cache_get(path_coverage_cache, cache_key);
   if (data) {
     return data;
   }
@@ -69,33 +70,47 @@ export async function get_path_coverage(path, changeset) {
   if (changeset && changeset !== REV_LATEST) {
     params += `&changeset=${changeset}`;
   }
+  if (platform && platform !== 'all') {
+    params += `&platform=${platform}`;
+  }
+  if (suite && suite !== 'all') {
+    params += `&suite=${suite}`;
+  }
   let response = await fetch(`${COVERAGE_BACKEND_HOST}/v2/path?${params}`).catch(alert);
   if (response.status !== 200) {
     throw new Error(response.status + ' - ' + response.statusText);
   }
   data = await response.json();
 
-  cache_set(path_coverage_cache, `${changeset}_${path}`, data);
+  cache_set(path_coverage_cache, cache_key, data);
 
   return data;
 }
 
 let history_cache = {};
-export async function get_history(path) {
+export async function get_history(path, platform, suite) {
   // Backend needs path without trailing /
   if (path && path.endsWith('/')) {
     path = path.substring(0, path.length-1);
   }
 
-  let data = cache_get(history_cache, path);
+  let cache_key = `${path}_${platform}_${suite}`;
+  let data = cache_get(history_cache, cache_key);
   if (data) {
     return data;
   }
 
-  let response = await fetch(`${COVERAGE_BACKEND_HOST}/v2/history?path=${path}`);
+  let params = `path=${path}`;
+  if (platform && platform !== 'all') {
+    params += `&platform=${platform}`;
+  }
+  if (suite && suite !== 'all') {
+    params += `&suite=${suite}`;
+  }
+  let response = await fetch(`${COVERAGE_BACKEND_HOST}/v2/history?${params}`);
   data = await response.json();
 
-  cache_set(history_cache, path, data);
+  cache_set(history_cache, cache_key, data);
 
   // Check data has coverage values
   // These values are missing when going above 2 levels right now
@@ -126,6 +141,22 @@ export async function get_zero_coverage_data() {
 }
 
 
+let filters_cache = {};
+export async function get_filters() {
+  let data = cache_get(filters_cache, '');
+  if (data) {
+    return data;
+  }
+
+  let response = await fetch(`${COVERAGE_BACKEND_HOST}/v2/filters`);
+  data = await response.json();
+
+  cache_set(filters_cache, '', data);
+
+  return data;
+}
+
+
 // Option handling.
 
 function is_enabled(opt) {

frontend/src/index.js

@@ -1,4 +1,4 @@
-import {REV_LATEST, DOM_READY, main, show, hide, message, get_path_coverage, get_history, get_zero_coverage_data, build_navbar, render, get_source} from './common.js';
+import {REV_LATEST, DOM_READY, main, show, hide, message, get_path_coverage, get_history, get_zero_coverage_data, build_navbar, render, get_source, get_filters} from './common.js';
 import {buildRoute, readRoute, updateRoute} from './route.js';
 import {zero_coverage_display, zero_coverage_menu} from './zero_coverage_report.js';
 import './style.css';
@@ -10,9 +10,21 @@ const VIEW_ZERO_COVERAGE = 'zero';
 const VIEW_BROWSER = 'browser';
 
 
-function browser_menu(revision) {
+function browser_menu(revision, filters, route) {
   let context = {
     revision,
+    platforms: filters.platforms.map((p) => {
+      return {
+        'name': p,
+        'selected': p == route.platform,
+      }
+    }),
+    suites: filters.suites.map((s) => {
+      return {
+        'name': s,
+        'selected': s == route.suite,
+      }
+    }),
   };
   render('menu_browser', context, 'menu');
 }
@@ -159,9 +171,10 @@ async function load() {
   }
 
   try {
-    var [coverage, history] = await Promise.all([
-      get_path_coverage(route.path, route.revision),
-      get_history(route.path),
+    var [coverage, history, filters] = await Promise.all([
+      get_path_coverage(route.path, route.revision, route.platform, route.suite),
+      get_history(route.path, route.platform, route.suite),
+      get_filters(),
     ]);
   } catch (err) {
     console.warn('Failed to load coverage', err);
@@ -177,6 +190,7 @@ async function load() {
     route,
     coverage,
     history,
+    filters,
   };
 }
 
@@ -187,7 +201,7 @@ async function display(data) {
     await zero_coverage_display(data.zero_coverage, data.path);
 
   } else if (data.view === VIEW_BROWSER) {
-    browser_menu(data.revision);
+    browser_menu(data.revision, data.filters, data.route);
 
     if (data.coverage.type === 'directory') {
       hide('message');