Do we have a possible circular import? #58

Closed
peterbe opened this Issue Aug 29, 2012 · 1 comment

1 participant

@peterbe

This is the first file to be imported:
https://github.com/mozilla/configman/blob/master/configman/__init__.py

Then, here https://github.com/mozilla/configman/blob/master/configman/__init__.py#L48 it imports
https://github.com/mozilla/configman/blob/master/configman/config_manager.py

Then, here https://github.com/mozilla/configman/blob/master/configman/config_manager.py#L48 it goes back to import configman/__init__.py again.

(funny that its line 48 in both files)

Surely this can't be healthy. I think it works because python import is idempotent so when it comes back to __init__.py it's able to "ignore" the second time.

@peterbe

config_manager.py no longer imports configman.

@peterbe peterbe closed this Aug 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment