Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Do we have a possible circular import? #58

Closed
peterbe opened this Issue · 1 comment

1 participant

Peter Bengtsson
Peter Bengtsson
Owner

This is the first file to be imported:
https://github.com/mozilla/configman/blob/master/configman/__init__.py

Then, here https://github.com/mozilla/configman/blob/master/configman/__init__.py#L48 it imports
https://github.com/mozilla/configman/blob/master/configman/config_manager.py

Then, here https://github.com/mozilla/configman/blob/master/configman/config_manager.py#L48 it goes back to import configman/__init__.py again.

(funny that its line 48 in both files)

Surely this can't be healthy. I think it works because python import is idempotent so when it comes back to __init__.py it's able to "ignore" the second time.

Peter Bengtsson
Owner

config_manager.py no longer imports configman.

Peter Bengtsson peterbe closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.