Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

number of clean up and housekeeping tasks #147

Merged
merged 1 commit into from Apr 28, 2015

Conversation

twobraids
Copy link
Contributor

this represents a number of tasks that clean up of various issues.

  1. prepare to support multiple command_line value sources. That means rework where we decide to do help
  2. add the ability to use a "$" suffix on an option to signal that the option is not to be written out to a configuration file. This will enable the future argparse support to have multiple arguments with the same name.
  3. move fetching value sources out the inner most loop in the overlay/expand loops. That is much more efficient.
  4. several formatting cleanups

@twobraids twobraids changed the title number of clean up housekeeping tasks number of clean up and housekeeping tasks Mar 30, 2015
@twobraids
Copy link
Contributor Author

@peterbe I've broken the argparse PR into two parts. This part makes some relatively minor changes to the core of configman. In the grand scheme of separating implementations, the next PR will only deal with adding files that support argparse and their registration in the configman core.

r?

from configman.config_exceptions import NotAnOptionError
from configman.config_file_future_proxy import ConfigFileFutureProxy
from configman.def_sources import setup_definitions
from configman.commandline import (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, i thought we had already merged the change that made the form of all the imports the same. We discussed a month or two ago about when to move to the multiline import form and when not to. I find that consistency is more readable than having two different forms of imports.

@peterbe
Copy link
Contributor

peterbe commented Mar 31, 2015

Nothing obvious sticking out except some low-hanging nits. I struggle to keep up with this whole argparse side of things since I'm not using or depending on it so my grey matters don't get the exercise.

peterbe pushed a commit that referenced this pull request Apr 28, 2015
number of clean up and housekeeping tasks
@peterbe peterbe merged commit ad4e414 into mozilla:master Apr 28, 2015
@twobraids twobraids deleted the housekeeping branch February 25, 2022 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants