Skip to content

Always pass types in value sources can_handle: use type(os.environ) instead of catching a TypeError and retrying #54

Open
wants to merge 2 commits into from

2 participants

@bsmedberg

No description provided.

bsmedberg added some commits Aug 14, 2012
@bsmedberg bsmedberg The jython implementation sometimes throws KeyError instead of TypeEr…
…ror for this exception, but as far as I can tell there's no reason to support "values or types" in this array, they should always be types.
dd521a4
@bsmedberg bsmedberg os.environ is not actually a dict. Make this change fully compatible …
…by just using type(os.environ)
da55a38
@bsmedberg

Oh, this passed nosetests (with cpython)

@peterbe
peterbe commented Aug 29, 2012

It appears actually to work. Great!

I'll try to talk to lars to look into this some more. Maybe we need to write more tests. Maybe we need to try to "prove your patch wrong" by employing some odd manual command line testing that only lars is able to conjure up. :)

Thanks in advance!

@peterbe
peterbe commented Sep 3, 2012

We have to wait for #57 because without we can't test this for jython.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.