New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?fbclid is being used to escape the container #178

Closed
floatingatoll opened this Issue Oct 23, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@floatingatoll

floatingatoll commented Oct 23, 2018

Facebook has introduced a new ?fbclid=... URL parameter that is appended to all outbound links. This sidesteps third-party cookie restrictions and permits associating someone's Container instance with their non-Container instance.

@TanviHacks

This comment has been minimized.

Collaborator

TanviHacks commented Oct 23, 2018

What would be the consequence of stripping fbclid whenever we switch out of the facebook container into another one?

Do we need to consider stripping it from facebook.com links too? So that if we are in some other container and about to open a facebook link in the facebook container, we don't include that parameter, in case it is used to link activity that happened in the previous container?

@groovecoder

This comment has been minimized.

Member

groovecoder commented Oct 23, 2018

There should be no problem stripping fbclid from the urls before entering or leaving the FB container.

groovecoder added a commit that referenced this issue Oct 23, 2018

groovecoder added a commit that referenced this issue Oct 25, 2018

groovecoder added a commit that referenced this issue Oct 25, 2018

groovecoder added a commit that referenced this issue Oct 31, 2018

Merge pull request #179 from mozilla/strip-fbclid-178
fix #178: strip fbclid from urls when reopening
@d-alleyne

This comment has been minimized.

d-alleyne commented Nov 10, 2018

Is there a way to get this code without waiting for AMO to update?

@groovecoder

This comment has been minimized.

Member

groovecoder commented Nov 11, 2018

Not easily. But I'll plan to update AMO tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment