Skip to content

/ contain-facebook

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FBC tool-tip appear as cut off on hovering #343

Closed
GeorgiuCiprian opened this issue May 10, 2019 · 1 comment
Closed

FBC tool-tip appear as cut off on hovering #343

GeorgiuCiprian opened this issue May 10, 2019 · 1 comment
Assignees
@maxxcrawford
Labels
P2 v2.0.0

Comments

@GeorgiuCiprian
Copy link

@GeorgiuCiprian GeorgiuCiprian commented May 10, 2019

Affected versions:

  • Firefox 66.0.5

Affected Platforms:

  • Windows 10 x64
  • Ubuntu 18.04 x64
  • macOS 10.13

Prerequisites:

Steps to reproduce:

  1. Go to this website.
  2. Hover over the purple badge from the Facebook share button.

Expected result:

  • FBC tool-tip is properly displayed.

Actual result:

  • FBC tool-tip appear as cut off.

Notes:

  • Please see the attached screenshot:

Screenshot from 2019-05-10 17-35-02
@maxxcrawford maxxcrawford self-assigned this May 10, 2019
maxxcrawford added a commit that referenced this issue May 10, 2019
@maxxcrawford
Fixed #343, Updated positionPrompt function to fire on hover and appl…
Loading status checks…
c34381b 
…y to both the prompt and the tooltip
@maxxcrawford maxxcrawford mentioned this issue May 10, 2019
Merged
@obotisan
Copy link

@obotisan obotisan commented May 14, 2019

We verified the fix on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13 by using FBC 1.7.1 and the bug is not reproducing anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxxcrawford maxxcrawford

Labels
P2 v2.0.0
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Content Script Fixes (Adding Site Selector, Minor Changes)
4 participants
@maxxcrawford @obotisan @GeorgiuCiprian @arthur-mozilla