Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain strings are not displayed as bolded on FBC doorhanger #584

Open
GeorgiuCiprian opened this issue Feb 17, 2020 · 3 comments
Open

Certain strings are not displayed as bolded on FBC doorhanger #584

GeorgiuCiprian opened this issue Feb 17, 2020 · 3 comments

Comments

@GeorgiuCiprian
Copy link

@GeorgiuCiprian GeorgiuCiprian commented Feb 17, 2020

Affected versions

  • Firefox 74.0b4

Affected platforms

  • Windows 10 x64
  • macOS 10.15
  • Ubuntu 18.04 x64

Steps to reproduce

  1. Download Facebook Container 2.1.0 .zip file and extract it.
  2. Launch Firefox and go to about:debugging#/runtime/this-firefox.
  3. Click on "Load Temporary Add-on...", then select manifest.json from the extracted archived.
  4. From the Url toolbar, click on the Facebook Container icon.
  5. From the door hanger, click on "How Facebook Container works".

Expected result

  • "Facebook Container" title and "even on pages you never like or share." string have a bold style as per specs.

Actual result

  • "Facebook Container" title and "even on pages you never like or share." string don't have a bold style as per specs.

Additional notes

  • This can be also observed on the specific door hanger displayed for Facebook domains (see screenshot no.2)
  • please observe the attached screenshot
    image

image

@maxxcrawford maxxcrawford self-assigned this Feb 17, 2020
@maxxcrawford
Copy link
Member

@maxxcrawford maxxcrawford commented Feb 18, 2020

@lesleyjanenorton How was this handled previously? I remember this being an issue during the 2.0 launch last summer (Specifically how the localized strings are concatenated).

@maxxcrawford
Copy link
Member

@maxxcrawford maxxcrawford commented Feb 18, 2020

cc/ @e-pang

@e-pang
Copy link

@e-pang e-pang commented Feb 18, 2020

if this is difficult and causes localization issues we can leave the bolded text as regular. Thanks!

@maxxcrawford maxxcrawford removed their assignment Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants