Skip to content

/ contain-facebook

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door hangers are not displayed for "Allow" and "Remove" functions #585

Closed
GeorgiuCiprian opened this issue Feb 17, 2020 · 1 comment
Closed

Door hangers are not displayed for "Allow" and "Remove" functions #585

GeorgiuCiprian opened this issue Feb 17, 2020 · 1 comment
Assignees
@maxxcrawford
Labels
has PR

Comments

@GeorgiuCiprian
Copy link

@GeorgiuCiprian GeorgiuCiprian commented Feb 17, 2020

Affected versions

  • Firefox 74.0b4

Affected platforms

  • Windows 10 x64
  • macOS 10.15
  • Ubuntu 18.04 x64

Steps to reproduce

  1. Download Facebook Container 2.1.0 .zip file and extract it.
  2. Launch Firefox and go to about:debugging#/runtime/this-firefox.
  3. Click on "Load Temporary Add-on...", then select manifest.json from the extracted archived.
  4. Navigate to https://www.google.com/ in a new tab.
  5. From the Url toolbar, click on the Facebook Container icon.
  6. Click on the "Allow Site in Facebook Container" option.

Expected result

  • A FBC door hanger is displayed with the "Allow" button, as per specs:

image

image

Actual result

  • There is no confirmation door hanger displayed after allowing or removing a website from FBC.
@maxxcrawford maxxcrawford self-assigned this Feb 17, 2020
@maxxcrawford maxxcrawford mentioned this issue Feb 17, 2020
Closed
maxxcrawford added a commit that referenced this issue Feb 17, 2020
@maxxcrawford
Fixed #585
Loading status checks…
b6b5502 
Added interstitial confirmation panel when adding site to the container.
Revised flow to include confirmation panel when removing site, if triggered from the main panel (and not the site list manager panel)
maxxcrawford added a commit that referenced this issue Feb 17, 2020
@maxxcrawford
Fixed #585
Loading status checks…
de85874 
Added interstitial confirmation panel when adding site to the container.
Revised flow to include confirmation panel when removing site, if triggered from the main panel (and not the site list manager panel)
@maxxcrawford maxxcrawford mentioned this issue Feb 20, 2020
Merged
maxxcrawford added a commit that referenced this issue Feb 26, 2020
@maxxcrawford
Fixed #585 - Added confirmation interstitial when adding/removing sit…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a67f760 
…es from the container (#589)

* Fixed #585
Added interstitial confirmation panel when adding site to the container.
Revised flow to include confirmation panel when removing site, if triggered from the main panel (and not the site list manager panel)
@gpalko-SV
Copy link

@gpalko-SV gpalko-SV commented Mar 4, 2020

I've verified the fix on build 2.1.0-rc2 and logged #608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxxcrawford maxxcrawford

Labels
has PR
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fixed #585 - Added confirmation interstitial when adding/removing sites from the container
3 participants
@maxxcrawford @GeorgiuCiprian @gpalko-SV